Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nextjs): add support for @testing-library/dom in application and library generators #30189

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

ndcunningham
Copy link
Contributor

Current Behavior

After creating a new Next.js application and running the spec file it fails OOTB.

Expected Behavior

Running the spec file after creating a new Next.js application should work.

Related Issue(s)

Fixes #

@ndcunningham ndcunningham added the scope: nextjs Issues related to NextJS support for Nx label Feb 26, 2025
@ndcunningham ndcunningham self-assigned this Feb 26, 2025
@ndcunningham ndcunningham requested a review from a team as a code owner February 26, 2025 17:47
Copy link

vercel bot commented Feb 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Feb 26, 2025 5:47pm

Copy link

nx-cloud bot commented Feb 26, 2025

View your CI Pipeline Execution ↗ for commit aa64f58.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 26m 56s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 14s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 37s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-26 18:19:56 UTC

@ndcunningham ndcunningham enabled auto-merge (squash) February 26, 2025 17:58
@ndcunningham ndcunningham merged commit 0ae4925 into master Feb 26, 2025
13 checks passed
@ndcunningham ndcunningham deleted the fix/nextjs-testing-jest-react-dom branch February 26, 2025 19:23
Copy link

github-actions bot commented Mar 4, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
scope: nextjs Issues related to NextJS support for Nx
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants