Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(rspack): handle potentially missing lockfile in @nx/rspack/plugin plugin #30086

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Feb 18, 2025

Current Behavior

If the lock file is missing the @nx/rspack/plugin plugin throws a cryptic error.

Expected Behavior

The @nx/rspack/plugin should handle a missing lock file.

Related Issue(s)

Fixes #

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
…n` plugin
@leosvelperez leosvelperez self-assigned this Feb 18, 2025
@leosvelperez leosvelperez requested a review from a team as a code owner February 18, 2025 11:01
Copy link

vercel bot commented Feb 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Feb 18, 2025 11:03am

Copy link

nx-cloud bot commented Feb 18, 2025

View your CI Pipeline Execution ↗ for commit a914dd8.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 20m 45s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 15s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 47s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-18 11:27:35 UTC

@leosvelperez leosvelperez requested a review from Coly010 February 18, 2025 11:11
@leosvelperez leosvelperez merged commit c782799 into master Feb 18, 2025
12 checks passed
@leosvelperez leosvelperez deleted the rspack/handle-missing-lockfile branch February 18, 2025 11:30
jaysoo pushed a commit that referenced this pull request Feb 18, 2025
…n` plugin (#30086)

## Current Behavior

If the lock file is missing the `@nx/rspack/plugin` plugin throws a
cryptic error.

## Expected Behavior

The `@nx/rspack/plugin` should handle a missing lock file.

## Related Issue(s)

Fixes #
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants