fix(core): Respect `extends` in local plugin TS options #30062

ethantkoenig · 2025-02-16T06:13:10Z

Fix a bug introduced in #29774.

Current Behavior

If a local plugin's tsconfig.json uses extends, the referenced base config is not loaded.

Expected Behavior

If a local plugin's tsconfig.json uses extends, the referenced base config is loaded.

Related Issue(s)

Fixes #30007

vercel · 2025-02-16T06:13:14Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
nx-dev	✅ Ready (Inspect)	Visit Preview	Feb 18, 2025 9:16am

nx-cloud · 2025-02-16T06:14:02Z

View your CI Pipeline Execution ↗ for commit b6fbb59.

Command	Status	Duration	Result
`nx affected --targets=lint,test,build,e2e,e2e-c...`	✅ Succeeded	36m 12s	View ↗
`nx run-many -t check-imports check-commit check...`	✅ Succeeded	15s	View ↗
`nx-cloud record -- nx-cloud conformance:check`	✅ Succeeded	2s	View ↗
`nx-cloud record -- nx format:check --base= --he...`	✅ Succeeded	5s	View ↗
`nx-cloud record -- nx sync:check`	✅ Succeeded	4s	View ↗
`nx documentation`	✅ Succeeded	2m 57s	View ↗

☁️ Nx Cloud last updated this comment at 2025-02-18 09:50:40 UTC

alumni · 2025-02-17T09:44:40Z

TypeError: s.codePointAt is not a function
    at codePointAt (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:14500:12)
    at codePointUnchecked (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:12073:12)
    at Object.scan (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:12684:18)
    at nextTokenWithoutCheck (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:33362:36)
    at nextToken (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:33372:12)
    at Object.parseJsonText2 [as parseJsonText] (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:32931:5)
    at parseJsonText (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:32759:17)
    at parseConfigFileTextToJson (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:42125:26)
    at readJsonOrUndefined (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:20956:18)
    at readJson (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:20960:10)
    at getPackageJsonInfo (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:45312)
    at <anonymous> (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:45244)
    at <anonymous> (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:45910)
    at forEachAncestorDirectory (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:9055)
    at forEachAncestorDirectoryStoppingAtGlobalCache (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:45909)
    at getPackageScopeForPath (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:45241)
    at loadModuleFromSelfNameReference (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:45412)
    at tryResolve (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:44888)
    at nodeModuleNameResolverWorker (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:44824)
    at nodeNextJsonConfigResolver (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:44772)
    at getExtendsConfigPath (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:43181)
    at getExtendsConfigPathOrArray (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:43078)
    at parseOwnConfigOfJson (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:43071)
    at parseConfig (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:43012)
    at parseJsonConfigFileContentWorker (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:42739)
    at Object.parseJsonConfigFileContent (<root>/node_modules/.pnpm/typescript@5.7.3/node_modules/typescript/lib/typescript.js:42691)
    at readTsConfigOptions (<root>/node_modules/.pnpm/nx@20.4.4_patch_hash=elh2fg32mryls3fzupnjo5fmoq_@swc-node+register@1.10.9_@swc+core@1.10.12_@_oj4vdjnizaxj3eefmlqqciq44y/node_modules/nx/src/plugins/js/utils/typescript.js:32)
    at registerPluginTSTranspiler (<root>/node_modules/.pnpm/nx@20.4.4_patch_hash=elh2fg32mryls3fzupnjo5fmoq_@swc-node+register@1.10.9_@swc+core@1.10.12_@_oj4vdjnizaxj3eefmlqqciq44y/node_modules/nx/src/project-graph/plugins/transpiler.js:27)
    at <anonymous> (<root>/node_modules/.pnpm/nx@20.4.4_patch_hash=elh2fg32mryls3fzupnjo5fmoq_@swc-node+register@1.10.9_@swc+core@1.10.12_@_oj4vdjnizaxj3eefmlqqciq44y/node_modules/nx/src/config/schema-utils.js:23)
    at runExecutorInternal (<root>/node_modules/.pnpm/nx@20.4.4_patch_hash=elh2fg32mryls3fzupnjo5fmoq_@swc-node+register@1.10.9_@swc+core@1.10.12_@_oj4vdjnizaxj3eefmlqqciq44y/node_modules/nx/src/command-line/run/run.js:97)
    at process.processTicksAndRejections (<node_internals>/internal/process/task_queues:95)
    at await (Unknown Source:0)
    at <anonymous> (<root>/node_modules/.pnpm/nx@20.4.4_patch_hash=elh2fg32mryls3fzupnjo5fmoq_@swc-node+register@1.10.9_@swc+core@1.10.12_@_oj4vdjnizaxj3eefmlqqciq44y/node_modules/nx/src/command-line/run/run.js:176)
    at handleErrors (<root>/node_modules/.pnpm/nx@20.4.4_patch_hash=elh2fg32mryls3fzupnjo5fmoq_@swc-node+register@1.10.9_@swc+core@1.10.12_@_oj4vdjnizaxj3eefmlqqciq44y/node_modules/nx/src/utils/handle-errors.js:8)
    at run (<root>/node_modules/.pnpm/nx@20.4.4_patch_hash=elh2fg32mryls3fzupnjo5fmoq_@swc-node+register@1.10.9_@swc+core@1.10.12_@_oj4vdjnizaxj3eefmlqqciq44y/node_modules/nx/src/command-line/run/run.js:174)
    at <anonymous> (<root>/node_modules/.pnpm/nx@20.4.4_patch_hash=elh2fg32mryls3fzupnjo5fmoq_@swc-node+register@1.10.9_@swc+core@1.10.12_@_oj4vdjnizaxj3eefmlqqciq44y/node_modules/nx/bin/run-executor.js:59)
    at emit (<node_internals>/events:518)
    at process.emit (<root>/node_modules/.pnpm/nx@20.4.4_patch_hash=elh2fg32mryls3fzupnjo5fmoq_@swc-node+register@1.10.9_@swc+core@1.10.12_@_oj4vdjnizaxj3eefmlqqciq44y/node_modules/nx/src/native/index.js:20)

leosvelperez

Thank you for contributing!

The change makes sense. I just requested a couple of changes to the test file but nothing major. If you don't have time to address them, please let me know and I'll update the PR.

packages/nx/src/plugins/js/utils/typescript.spec.ts

alumni · 2025-02-17T13:00:58Z

Thank you for contributing!

The change makes sense. I just requested a couple of changes to the test file but nothing major. If you don't have time to address them, please let me know and I'll update the PR.

@leosvelperez it still fails for workspace plugins (see the stack trace above).

Edit 1: While debugging I noticed the issue is not with the tools/workspace-plugin/tsconfig.json anymore, but with tsconfig.base.json which extends from @tsconfig/node20/tsconfig.json.

Edit 2: Somehow it fails when parsing the package.json of the monorepo.

Edit 3: I noticed directoryExists was needed, so I added that to host, but it started to break somewhere else. I think resolving the TSConfig relies on the entire ParseConfigHost, it's not something we can avoid.

leosvelperez · 2025-02-17T15:36:39Z

@alumni thanks for the extra feedback and testing!

@ethantkoenig we should update the host to:

const host: Partial<ts.ParseConfigHost> = {
  ...tsModule.sys,
  readDirectory: () => [],
};

That way, we have everything that's needed to read the config files (including extended config files from third-party packages) while still avoiding scanning directories, which are only used to identify the fileNames property in the parsed configuration.

Please add extra test cases that cover extending from third-party packages.

alumni · 2025-02-17T15:55:48Z

const host: Partial<ts.ParseConfigHost> = {
  ...tsModule.sys,
  readDirectory: () => [],
};

Seems to work for the project config that I have.

Partial might not be necessary, ParseConfigHost seems to be a subset of System.

Thanks both :)

ethantkoenig · 2025-02-17T18:29:07Z

@ethantkoenig we should update the host to:
const host: Partial<ts.ParseConfigHost> = {
  ...tsModule.sys,
  readDirectory: () => [],
};
That way, we have everything that's needed to read the config files (including extended config files from third-party packages) while still avoiding scanning directories, which are only used to identify the fileNames property in the parsed configuration.

Done

Please add extra test cases that cover extending from third-party packages.

Added a test, though I was unable to come up with a third-party test case that fails with the old code, so the test might not be super useful. @alumni if you have a minimal reproducible example you are able to easily share, that would be helpful.

Fix a bug introduced in #29774. ## Current Behavior If a local plugin's `tsconfig.json` uses `extends`, the referenced base config is not loaded. ## Expected Behavior If a local plugin's `tsconfig.json` uses `extends`, the referenced base config is loaded. ## Related Issue(s) Fixes #30007 --------- Co-authored-by: Leosvel Pérez Espinosa <leosvel.perez.espinosa@gmail.com>

github-actions · 2025-02-24T00:10:27Z

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

ethantkoenig mentioned this pull request Feb 16, 2025

Default imports broken in custom executor in 20.4.1 #30007

Closed

4 tasks

ethantkoenig force-pushed the master branch from 893ba6d to a7d707d Compare February 16, 2025 21:48

fix(core): Respect extends in local plugin TS options

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

Loading
Loading status checks…

98d3418

ethantkoenig force-pushed the master branch from a7d707d to 98d3418 Compare February 16, 2025 23:15

ethantkoenig marked this pull request as ready for review February 17, 2025 00:32

ethantkoenig requested a review from a team as a code owner February 17, 2025 00:32

ethantkoenig requested a review from Cammisuli February 17, 2025 00:32

leosvelperez requested changes Feb 17, 2025

View reviewed changes

packages/nx/src/plugins/js/utils/typescript.spec.ts Outdated Show resolved Hide resolved

packages/nx/src/plugins/js/utils/typescript.spec.ts Outdated Show resolved Hide resolved

ethantkoenig added 2 commits February 17, 2025 09:17

fix(core): PR feedback

Loading
Loading status checks…

5b8f2f3

fix(core): third-party test

Loading
Loading status checks…

8c6c53d

ethantkoenig requested a review from leosvelperez February 17, 2025 18:29

Merge branch 'master' into master

Loading
Loading status checks…

b6fbb59

leosvelperez approved these changes Feb 18, 2025

View reviewed changes

leosvelperez enabled auto-merge (squash) February 18, 2025 09:08

vercel bot deployed to Preview February 18, 2025 09:16 View deployment

leosvelperez disabled auto-merge February 18, 2025 09:19

leosvelperez enabled auto-merge (squash) February 18, 2025 09:21

leosvelperez merged commit 9cdc1cc into nrwl:master Feb 18, 2025
12 checks passed

philipjfulcher mentioned this pull request Feb 21, 2025

docs(nx-dev): publish GraphQL article #30136

Merged

github-actions bot locked as resolved and limited conversation to collaborators Feb 24, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(core): Respect `extends` in local plugin TS options #30062

fix(core): Respect `extends` in local plugin TS options #30062

ethantkoenig commented Feb 16, 2025

vercel bot commented Feb 16, 2025 •

edited

Loading

nx-cloud bot commented Feb 16, 2025 •

edited

Loading

alumni commented Feb 17, 2025 •

edited

Loading

leosvelperez left a comment

alumni commented Feb 17, 2025 •

edited

Loading

leosvelperez commented Feb 17, 2025 •

edited

Loading

alumni commented Feb 17, 2025 •

edited

Loading

ethantkoenig commented Feb 17, 2025

github-actions bot commented Feb 24, 2025

fix(core): Respect extends in local plugin TS options #30062

fix(core): Respect extends in local plugin TS options #30062

Conversation

ethantkoenig commented Feb 16, 2025

Current Behavior

Expected Behavior

Related Issue(s)

vercel bot commented Feb 16, 2025 • edited Loading

nx-cloud bot commented Feb 16, 2025 • edited Loading

alumni commented Feb 17, 2025 • edited Loading

leosvelperez left a comment

Choose a reason for hiding this comment

alumni commented Feb 17, 2025 • edited Loading

leosvelperez commented Feb 17, 2025 • edited Loading

alumni commented Feb 17, 2025 • edited Loading

ethantkoenig commented Feb 17, 2025

github-actions bot commented Feb 24, 2025

fix(core): Respect `extends` in local plugin TS options #30062

fix(core): Respect `extends` in local plugin TS options #30062

vercel bot commented Feb 16, 2025 •

edited

Loading

nx-cloud bot commented Feb 16, 2025 •

edited

Loading

alumni commented Feb 17, 2025 •

edited

Loading

alumni commented Feb 17, 2025 •

edited

Loading

leosvelperez commented Feb 17, 2025 •

edited

Loading

alumni commented Feb 17, 2025 •

edited

Loading