Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): handle nullable lock when creating project graph #30000

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Feb 12, 2025

Current Behavior

The project graph construction can throw an error when the lock is not created: #29821 (comment).

Expected Behavior

The project graph construction should correctly handle the nullable lock.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Feb 12, 2025
@leosvelperez leosvelperez requested a review from a team as a code owner February 12, 2025 12:03
Copy link

vercel bot commented Feb 12, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Feb 12, 2025 0:03am

Copy link

nx-cloud bot commented Feb 12, 2025

View your CI Pipeline Execution ↗ for commit c589e62.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 39m 59s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 20s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 11s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 9s View ↗
nx documentation ✅ Succeeded 2m 59s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-12 12:51:23 UTC

@AgentEnder AgentEnder merged commit 672318d into master Feb 12, 2025
12 checks passed
@AgentEnder AgentEnder deleted the core/fix-nullable-lock-access branch February 12, 2025 17:21
jaysoo pushed a commit that referenced this pull request Feb 12, 2025
## Current Behavior

The project graph construction can throw an error when the lock is not
created:
#29821 (comment).

## Expected Behavior

The project graph construction should correctly handle the nullable
lock.

## Related Issue(s)

Fixes #
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 18, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants