fix(angular): do not generate @nx/dependency-checks block in flat root eslint config
#29980
+277
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oot eslint config
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit bfafb83.
☁️ Nx Cloud last updated this comment at |
Coly010
approved these changes
Feb 11, 2025
leosvelperez
deleted the
angular/fix-eslint-duplicated-dependency-checks-block
branch
jaysoo
pushed a commit
that referenced
this pull request
Feb 12, 2025
…oot eslint config (#29980) ## Current Behavior Generating a buildable Angular library results in a block for the `@nx/dependency-checks` being added to the root ESLint Flat Config file every time. ## Expected Behavior Generating a buildable Angular library should not add a block for the `@nx/dependency-checks` to the root ESLint Flat Config file. The configuration is meant to be added to the project configuration, which it already does. ## Related Issue(s) Fixes #29970
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Generating a buildable Angular library results in a block for the
@nx/dependency-checksbeing added to the root ESLint Flat Config file every time.Expected Behavior
Generating a buildable Angular library should not add a block for the
@nx/dependency-checksto the root ESLint Flat Config file. The configuration is meant to be added to the project configuration, which it already does.Related Issue(s)
Fixes #29970