fix(testing): move webpack and vite to optional peer dep #29800
Merged
+31
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit 1981c8d.
☁️ Nx Cloud last updated this comment at |
@nx/webpack and @nx/vite are used for a single migration but pollute the overall dep size of someone using @nx/playwright without bothe vite and webpack. This change allows users to only install the one stack they are using.
AgentEnder
force-pushed
the
fix/testing-move-vite-webpack-to-optional-peer-dep
branch
from
875af29 to
1981c8d
Compare
leosvelperez
approved these changes
Jan 29, 2025
AgentEnder
deleted the
fix/testing-move-vite-webpack-to-optional-peer-dep
branch
FrozenPandaz
pushed a commit
that referenced
this pull request
Feb 6, 2025
@nx/webpack and @nx/vite are used for a single migration but pollute the overall dep size of someone using @nx/playwright without both vite and webpack. This change allows users to only install the one stack they are using. (cherry picked from commit a5f13a2)
FrozenPandaz
added a commit
that referenced
this pull request
Feb 7, 2025
)" This reverts commit a5f13a2.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@nx/webpack and @nx/vite are used for a single migration but pollute the overall dep size of someone using @nx/playwright without both vite and webpack. This change allows users to only install the one stack they are using.