Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gradle): fix dependencies.txt not found #29787

Merged
merged 1 commit into from
Jan 29, 2025

Conversation

xiongemi
Copy link
Collaborator

@xiongemi xiongemi commented Jan 28, 2025

Current Behavior

  • currently, when cache project report, it caches buildFileToDepsMap, which is a map of build file to path of dependencies.txt
  • however, when we try to read dependencies.txt in create dependencies, it might not exist

Expected Behavior

  • read the dependencies.txt file when process project report to cache
  • cache dependencies as processed project report result
  • no need to read dependencies.txt in create dependencies

Related Issue(s)

Fixes #

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 28, 2025 7:58pm

Copy link

nx-cloud bot commented Jan 28, 2025

View your CI Pipeline Execution ↗ for commit 08f40ba.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 14m 17s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m 2s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=67f12... ✅ Succeeded 21s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 19s View ↗
nx documentation --no-dte ✅ Succeeded 43s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-28 20:15:30 UTC

@xiongemi xiongemi force-pushed the fix/fix-gradle-dependencies-file-not-found branch from cb844f2 to 08f40ba Compare January 28, 2025 19:55
@xiongemi xiongemi changed the title fix(gradle): dependencies.txt not found fix(gradle): fix dependencies.txt not found Jan 28, 2025
@xiongemi xiongemi merged commit 8754e38 into master Jan 29, 2025
5 checks passed
@xiongemi xiongemi deleted the fix/fix-gradle-dependencies-file-not-found branch January 29, 2025 15:50
Copy link

github-actions bot commented Feb 4, 2025

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 4, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants