fix(core): do not check open connections during inactivity #29621
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
|
View your CI Pipeline Execution ↗ for commit e748bd9.
☁️ Nx Cloud last updated this comment at |
FrozenPandaz
force-pushed
the
inactivity
branch
2 times, most recently
from
beb3d05 to
a2233d5
Compare
FrozenPandaz
force-pushed
the
inactivity
branch
from
a2233d5 to
e748bd9
Compare
Cammisuli
approved these changes
Jan 14, 2025
AgentEnder
approved these changes
Jan 15, 2025
AgentEnder
approved these changes
Jan 15, 2025
FrozenPandaz
added a commit
that referenced
this pull request
Jan 15, 2025
…own (#29621) <!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- If this is a particularly complex change or feature addition, you can request a dedicated Nx release for this pull request branch. Mention someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they will confirm if the PR warrants its own release for testing purposes, and generate it for you if appropriate. --> ## Current Behavior <!-- This is the behavior we have today --> We currently second guess our inactivity timer by checking if there are any open connections. However, there's also a strong chance that plugin workers will remain open as long as the daemon is open. This means the daemon stays alive forever and the daemon never shuts down even though it is inactive. ## Expected Behavior <!-- This is the behavior we should expect with the changes in this PR --> Instead of checking for open connections in general, the daemon server will only check for open file watchers. Most Daemon client requests will restart the server when sending messages so we can safely shut the server down in most cases. The only case where shutting down the daemon would cause a disruption is if a file watcher is registered. In those cases, the daemon will not shutdown due to inactivity. ## Related Issue(s) <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes # (cherry picked from commit 32a2ca8)
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We currently second guess our inactivity timer by checking if there are any open connections. However, there's also a strong chance that plugin workers will remain open as long as the daemon is open. This means the daemon stays alive forever and the daemon never shuts down even though it is inactive.
Expected Behavior
Instead of checking for open connections in general, the daemon server will only check for open file watchers. Most Daemon client requests will restart the server when sending messages so we can safely shut the server down in most cases. The only case where shutting down the daemon would cause a disruption is if a file watcher is registered. In those cases, the daemon will not shutdown due to inactivity.
Related Issue(s)
Fixes #