Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(core): change graph node type and name to string #29610

Merged
merged 1 commit into from
Mar 4, 2025
Merged

fix(core): change graph node type and name to string #29610

merged 1 commit into from
Mar 4, 2025
+79 −57

Conversation

xiongemi
Copy link
Collaborator

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@xiongemi xiongemi requested review from a team as code owners January 13, 2025 23:14
@vercel Vercel
Copy link

vercel bot commented Jan 13, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Mar 4, 2025 5:37pm

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 13, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit 3dfbdf1.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 40m 27s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 17s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base=437ba... ✅ Succeeded 2s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 1s View ↗
nx documentation ✅ Succeeded 2m View ↗

☁️ Nx Cloud last updated this comment at 2025-03-04 18:09:05 UTC

@xiongemi xiongemi force-pushed the fix/add-cargo-node-type branch from b609459 to e17c98b Compare January 14, 2025 02:01
@xiongemi xiongemi force-pushed the fix/add-cargo-node-type branch from e17c98b to 929f773 Compare January 16, 2025 17:01
AgentEnder
AgentEnder requested changes Jan 16, 2025
View reviewed changes
@xiongemi xiongemi force-pushed the fix/add-cargo-node-type branch from 929f773 to 7591790 Compare January 17, 2025 22:19
@xiongemi xiongemi force-pushed the fix/add-cargo-node-type branch from 7591790 to ce03dd1 Compare January 22, 2025 17:02
@xiongemi xiongemi requested a review from AgentEnder January 22, 2025 18:38
@xiongemi xiongemi changed the title fix(core): add cargo and gradle to external graph node type fix(core): change graph node type to string Feb 19, 2025
@xiongemi xiongemi changed the title fix(core): change graph node type to string fix(core): change graph node type and name to string Feb 19, 2025
@xiongemi xiongemi force-pushed the fix/add-cargo-node-type branch from ce03dd1 to 3dfbdf1 Compare March 4, 2025 17:22
@xiongemi xiongemi merged commit 04cf098 into master Mar 4, 2025
12 checks passed
@xiongemi xiongemi deleted the fix/add-cargo-node-type branch March 4, 2025 21:41
@github-actions GitHub Actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AgentEnder AgentEnder

@FrozenPandaz FrozenPandaz

@leosvelperez leosvelperez

Assignees

@xiongemi xiongemi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xiongemi @AgentEnder