Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): do not set project references to non-existing tsconfig files in sync generator #29536

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

leosvelperez
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
… in sync generator
@leosvelperez leosvelperez requested a review from jaysoo January 7, 2025 12:47
@leosvelperez leosvelperez self-assigned this Jan 7, 2025
@leosvelperez leosvelperez requested a review from a team as a code owner January 7, 2025 12:47
Copy link

vercel bot commented Jan 7, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Jan 7, 2025 0:49am

Copy link

nx-cloud bot commented Jan 7, 2025

View your CI Pipeline Execution ↗ for commit dbd998f.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 37m 57s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 18s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 1s View ↗
nx-cloud record -- nx format:check --base=82751... ✅ Succeeded 1s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded <1s View ↗
nx documentation --no-dte ✅ Succeeded <1s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-07 13:30:30 UTC

@leosvelperez leosvelperez merged commit 160800e into master Jan 8, 2025
6 checks passed
@leosvelperez leosvelperez deleted the js/fix-reference-to-non-existing-tsconfig branch January 8, 2025 15:45
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 14, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants