Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(release): allow preid option in release command #29264

Merged

Conversation

focusaway
Copy link
Contributor

Current Behavior

Currently the release command does not allow passing a preid that defines channels as alpha or beta. When trying to pass it, it throws the error that it is an unknown option:
image

Expected Behavior

Allow defining a preid from the release command. It is added to the command line interface without affecting internal operation since the arguments are passed directly to the versioning command
image

Related Issue(s)

Fixes #27878

@focusaway focusaway requested a review from a team as a code owner December 9, 2024 14:24
Copy link

vercel bot commented Dec 9, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Feb 15, 2025 9:51am

Copy link

nx-cloud bot commented Dec 9, 2024

View your CI Pipeline Execution ↗ for commit 48620f3.

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 36m 12s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 16s View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded 2s View ↗
nx-cloud record -- nx format:check --base= --he... ✅ Succeeded 6s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 5s View ↗
nx documentation ✅ Succeeded 1m 34s View ↗

☁️ Nx Cloud last updated this comment at 2025-02-15 10:21:22 UTC

Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation looks good

@focusaway focusaway force-pushed the fix/add-preid-option-in-release-command branch from b389e46 to a0ffa95 Compare December 17, 2024 16:05
Copy link

nx-cloud bot commented Dec 17, 2024

Your CI Pipeline Execution ↗ for commit a0ffa95 has failed ❌

Command Status Duration Result
nx affected --targets=lint,test,build,e2e,e2e-c... ✅ Succeeded 54m 13s View ↗
nx run-many -t check-imports check-commit check... ✅ Succeeded 1m View ↗
nx-cloud record -- nx-cloud conformance:check ✅ Succeeded <1s View ↗
nx-cloud record -- nx format:check --base=ee4de... ✅ Succeeded 23s View ↗
nx-cloud record -- nx sync:check ✅ Succeeded 21s View ↗
nx documentation --no-dte ✅ Succeeded 1m 3s View ↗

☁️ Nx Cloud last updated this comment at 2024-12-17 17:08:12 UTC

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@JamesHenry JamesHenry merged commit d834514 into nrwl:master Feb 17, 2025
12 checks passed
@JamesHenry
Copy link
Collaborator

Thank you @focusaway!

Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

unable to pass --preid to command nx release preminor
3 participants