Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): vite should be default bundler in app generator #28013

Merged
merged 1 commit into from
Sep 20, 2024

Conversation

juristr
Copy link
Member

@juristr juristr commented Sep 20, 2024

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@juristr juristr requested review from a team as code owners September 20, 2024 14:58
Copy link

vercel bot commented Sep 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview Sep 20, 2024 3:07pm

@juristr juristr self-assigned this Sep 20, 2024
@jaysoo jaysoo merged commit c50acf7 into master Sep 20, 2024
6 checks passed
@jaysoo jaysoo deleted the react/fix-default-bundler branch September 20, 2024 16:12
FrozenPandaz pushed a commit that referenced this pull request Sep 25, 2024

Verified

This commit was signed with the committer’s verified signature.
FrozenPandaz Jason Jean
<!-- Please make sure you have read the submission guidelines before
posting an PR -->
<!--
https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr
-->

<!-- Please make sure that your commit message follows our format -->
<!-- Example: `fix(nx): must begin with lowercase` -->

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit c50acf7)
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 26, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants