Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow prompts from init generators during nx init #28003

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Sep 19, 2024

This PR allows init generators to prompt during nx init.

Demo (temporarily adds prompt to vite init): https://www.loom.com/share/ad40e6f02186478596ea6e1f08dba7a4

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@jaysoo jaysoo requested a review from a team as a code owner September 19, 2024 17:36
@jaysoo jaysoo requested a review from xiongemi September 19, 2024 17:36
Copy link

vercel bot commented Sep 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Sep 19, 2024 5:39pm

@FrozenPandaz FrozenPandaz merged commit 4fedc40 into master Sep 23, 2024
6 checks passed
@FrozenPandaz FrozenPandaz deleted the feat/init-prompts branch September 23, 2024 14:43
FrozenPandaz pushed a commit that referenced this pull request Sep 25, 2024
This PR allows init generators to prompt during `nx init`.

Demo (temporarily adds prompt to vite init):
https://www.loom.com/share/ad40e6f02186478596ea6e1f08dba7a4

<!-- If this is a particularly complex change or feature addition, you
can request a dedicated Nx release for this pull request branch. Mention
someone from the Nx team or the `@nrwl/nx-pipelines-reviewers` and they
will confirm if the PR warrants its own release for testing purposes,
and generate it for you if appropriate. -->

## Current Behavior
<!-- This is the behavior we have today -->

## Expected Behavior
<!-- This is the behavior we should expect with the changes in this PR
-->

## Related Issue(s)
<!-- Please link the issue being fixed so it gets closed when this is
merged. -->

Fixes #

(cherry picked from commit 4fedc40)
Copy link

github-actions bot commented Oct 1, 2024

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants