fix(bundling): load rollup config using the rollup version installed in the workspace #26298
+29
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit a8fd0cc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
fix/rollup-axios-NXC-683
branch
2 times, most recently
from
1363fb5 to
cc55daf
Compare
FrozenPandaz
requested changes
May 31, 2024
jaysoo
force-pushed
the
fix/rollup-axios-NXC-683
branch
from
cc55daf to
5bfb685
Compare
FrozenPandaz
approved these changes
Jun 5, 2024
<!-- Please make sure you have read the submission guidelines before posting an PR --> <!-- https://github.com/nrwl/nx/blob/master/CONTRIBUTING.md#-submitting-a-pr --> <!-- Please make sure that your commit message follows our format --> <!-- Example: `fix(nx): must begin with lowercase` --> <!-- This is the behavior we have today --> - nx run will not have quotes, but underlying command will have <!-- This is the behavior we should expect with the changes in this PR --> <img width="524" alt="Screenshot 2024-05-23 at 2 07 20 PM" src="https://github.com/nrwl/nx/assets/16211801/7c96f884-3c11-4f56-b6b4-b3fd41ac2187"> <img width="471" alt="Screenshot 2024-05-23 at 2 07 03 PM" src="https://github.com/nrwl/nx/assets/16211801/b6746a25-ebfc-4cb2-ad1d-4f8600782037"> <!-- Please link the issue being fixed so it gets closed when this is merged. --> Fixes #
jaysoo
force-pushed
the
fix/rollup-axios-NXC-683
branch
from
5bfb685 to
a8fd0cc
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates
@nx/rollup/pluginso it loads the config file usingloadConfigFilefrom the Rollup version installed in the workspace.This fixes the issue when initializing in the axios repo, since the
requirecall in their config is no longer valid ESM in Rollup 4.Current Behavior
Expected Behavior
Related Issue(s)
Fixes #