fix(core): load config util supports absolute paths on windows #22837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 9e680ac. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
Coly010
force-pushed
the
windows-load-config-fix
branch
from
1d725f7
to
9e5803a
Compare
jaysoo
approved these changes
Apr 16, 2024
FrozenPandaz
requested changes
Apr 16, 2024
Coly010
force-pushed
the
windows-load-config-fix
branch
from
9e5803a
to
9e680ac
Compare
FrozenPandaz
approved these changes
Apr 17, 2024
FrozenPandaz
pushed a commit
that referenced
this pull request
Apr 18, 2024
(cherry picked from commit 82145e7)
AgentEnder
pushed a commit
to AgentEnder/nx
that referenced
this pull request
Apr 23, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
when a plugin attempts to load an ESM config file during graph creation with an absolute path on windows, it falls over as the protocol is unsupported.
Expected Behavior
Use pathToFileURl to correctly form the path needed for ESM config files to be imported.
Related Issue(s)
Fixes #21936