fix(bundling): handle circular dependencies in @nx/esbuild getExtraDependencies #22644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 298879e. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
…pendencies In more complex projects, there can be circular dependencies that can cause the maximum call stack exeeced error. To work around this issue, we will track previously visited nodes to avoid runaway recursion.
kylecannon
force-pushed
the
allow_circular_dependencies_in_get_extra_dependencies
branch
from
1e0f81f
to
298879e
Compare
jaysoo
approved these changes
Apr 18, 2024
AgentEnder
pushed a commit
to AgentEnder/nx
that referenced
this pull request
Apr 23, 2024
kylecannon
deleted the
allow_circular_dependencies_in_get_extra_dependencies
branch
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
In projects that have circular dependencies, @nx/esbuild is unable to be ran because
getExtraDependenciesdoes not guard against circular references, causing:RangeError: Maximum call stack size exceededExpected Behavior
getExtraDependenciesshould guard against circular references without crashing.