feat(devkit): add loadConfigFile function for plugins to use #21511
+94
−108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 8ab3bd8. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this CI Pipeline Execution ✅ Successfully ran 6 targets
Sent with 💌 from NxCloud. |
jaysoo
force-pushed
the
config_cache_bust
branch
3 times, most recently
from
b53117d to
591827d
Compare
jaysoo
changed the title
jaysoo
force-pushed
the
config_cache_bust
branch
from
591827d to
8ab3bd8
Compare
FrozenPandaz
approved these changes
Feb 2, 2024
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
loadConfigFilefunction to@nx/devkitso plugins can use it to read config files in both CJS and ESM format. TS config files are handled as well.We try to load via
requirefirst, which should be faster and has better cache busting guarantees. If that fails, then we try to load usingimport()because it is likely ESM.The ESM case should only happen when either:
.mjs.tsor.jsandpackage.jsonspecifies"type": "module"By default (1) would be used for Nx workspaces, however repos like epic-stack uses ESM.
Current Behavior
Sometimes cache is not busted using
import().Expected Behavior
Prefer
requirefor better cache busting, but fallback toimport()which should work as well with?t=....appended.