Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): update to vitest v1 #20747

Merged
merged 2 commits into from
Dec 14, 2023
Merged

Conversation

mandarini
Copy link
Member

@mandarini mandarini commented Dec 13, 2023

coverage: {
      thresholds: {
        lines: 100,
        statements: 100,
        functions: 100,
        branches: 1000,
      },
    },

Copy link

vercel bot commented Dec 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Visit Preview Dec 14, 2023 2:32pm

@mandarini mandarini force-pushed the feat/update-vitest-1 branch from 8ef1c12 to bee7bcb Compare December 13, 2023 16:43
@mandarini mandarini self-assigned this Dec 13, 2023
@mandarini mandarini marked this pull request as ready for review December 13, 2023 16:44
@mandarini mandarini requested review from a team as code owners December 13, 2023 16:44
@mandarini mandarini requested a review from jaysoo December 13, 2023 16:47
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changelog seemed pretty dense when I saw it a few days ago, were there no generated config changes (and associated migrations) necessary?

packages/vite/package.json Outdated Show resolved Hide resolved
@mandarini
Copy link
Member Author

@JamesHenry works on my machine :P
I mean, I tried it on a couple of repos locally and the tests seemed to run ok. For the next cycle, I will look more into any new features they have for monorepos or anything we do want to support. But just for running the tests with our executors, and the bare-minimum we generate, it seems to be working ok?

@JamesHenry
Copy link
Collaborator

Ok cool, we can see if CI can pass ok to be sure

@mandarini mandarini merged commit cac2c17 into nrwl:master Dec 14, 2023
6 checks passed
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Vitest v1 outdated peer dependency in @nx/vite package.json
5 participants