Skip to content

Commit

Permalink
fix(misc): pin generated vite version to ~5.0.0 to avoid issues with …
Browse files Browse the repository at this point in the history
…storybook (#21740)

(cherry picked from commit d2272fd)
  • Loading branch information
leosvelperez authored and FrozenPandaz committed Feb 9, 2024
1 parent efdda7b commit ad43e66
Show file tree
Hide file tree
Showing 8 changed files with 8 additions and 8 deletions.
2 changes: 1 addition & 1 deletion e2e/nuxt/src/nuxt.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ describe('Nuxt Plugin', () => {

beforeAll(() => {
newProject({
packages: ['@nx/nuxt', '@nx/storybook'],
packages: ['@nx/nuxt'],
unsetProjectNameAndRootFormat: false,
});
runCLI(
Expand Down
2 changes: 1 addition & 1 deletion e2e/storybook/src/storybook.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ describe('Storybook generators and executors for monorepos', () => {
let proj;
beforeAll(async () => {
proj = newProject({
packages: ['@nx/react', '@nx/storybook'],
packages: ['@nx/react'],
unsetProjectNameAndRootFormat: false,
});
runCLI(
Expand Down
2 changes: 1 addition & 1 deletion e2e/vue/src/vue-storybook.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ describe('Storybook generators and executors for Vue projects', () => {
originalEnv = process.env.NX_ADD_PLUGINS;
process.env.NX_ADD_PLUGINS = 'true';
proj = newProject({
packages: ['@nx/vue', '@nx/storybook'],
packages: ['@nx/vue'],
unsetProjectNameAndRootFormat: false,
});
runCLI(
Expand Down
2 changes: 1 addition & 1 deletion packages/cypress/src/utils/versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -5,5 +5,5 @@ export const cypressViteDevServerVersion = '^2.2.1';
export const cypressVersion = '^13.0.0';
export const cypressWebpackVersion = '^2.0.0';
export const webpackHttpPluginVersion = '^5.5.0';
export const viteVersion = '^5.0.0';
export const viteVersion = '~5.0.0';
export const htmlWebpackPluginVersion = '^5.5.0';
2 changes: 1 addition & 1 deletion packages/storybook/src/utils/versions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,6 @@ export const tsLibVersion = '^2.3.0';

export const storybookVersion = '^7.5.3';
export const reactVersion = '^18.2.0';
export const viteVersion = '^5.0.0';
export const viteVersion = '~5.0.0';

export const coreJsVersion = '^3.6.5';
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ exports[`@nx/vite:init dependencies for package.json should add required package
"@nx/web": "0.0.1",
"@vitest/ui": "^1.0.4",
"existing": "1.0.0",
"vite": "^5.0.0",
"vite": "~5.0.0",
"vitest": "^1.0.4",
},
"name": "@proj/source",
Expand Down
2 changes: 1 addition & 1 deletion packages/vite/src/utils/versions.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
export const nxVersion = require('../../package.json').version;
export const viteVersion = '^5.0.0';
export const viteVersion = '~5.0.0';
export const vitestVersion = '^1.0.4';
export const vitePluginReactVersion = '^4.2.0';
export const vitePluginReactSwcVersion = '^3.5.0';
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -196,7 +196,7 @@ exports[`lib should add vue, vite and vitest to package.json 1`] = `
"jsdom": "~22.1.0",
"prettier": "^2.6.2",
"typescript": "~5.3.2",
"vite": "^5.0.0",
"vite": "~5.0.0",
"vitest": "^1.0.4",
"vue-tsc": "^1.8.8",
},
Expand Down

0 comments on commit ad43e66

Please sign in to comment.