fix: only use latest template-oss specific commits in changelog #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wraithgar
approved these changes
Apr 15, 2024
Merged
lukekarrys
pushed a commit
that referenced
this pull request
Apr 15, 2024
🤖 I have created a release *beep* *boop* --- ## [4.21.4](v4.21.3...v4.21.4) (2024-04-15) ### Bug Fixes * [`b8cf803`](b8cf803) [#430](#430) only use latest template-oss specific commits in changelog (#430) (@lukekarrys) * [`5d806ab`](5d806ab) [#429](#429) iterate over releases from env var (#429) (@lukekarrys) * [`8906397`](8906397) [#423](#423) turn of body-max-line-length commitlint rule (@lukekarrys) ### Dependencies * [`0b1c048`](0b1c048) [#423](#423) `@commitlint/config-conventional@19.2.2` * [`47e9d8d`](47e9d8d) [#423](#423) bump @commitlint/cli from 18.6.1 to 19.0.3 (@dependabot[bot]) * [`41ee083`](41ee083) [#425](#425) bump undici from 5.28.3 to 6.7.0 (#425) (@dependabot[bot]) * [`1106838`](1106838) [#427](#427) `proc-log@4.0.0` (#427) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This was referenced Apr 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is tested with mocked commits within
template-ossbecause it's still hard to test this kind of stuff intergration style withrelease-please.I did manually run this code against https://github.com/npm/npm-cli-release-please and for two PRs with the
postinstall for dependabot template-osscommit message, only one made it to the changelog. npm/npm-cli-release-please#246Screenshots since any links to that repo might change due to other tests. Note that only PR
#274is in the changelog and not#273.