TypeScript, ESM, tap18 support #371
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukekarrys
force-pushed
the
lk/latest-npm
branch
5 times, most recently
from
b3e3852
to
5bbb239
Compare
lukekarrys
force-pushed
the
lk/latest-npm
branch
15 times, most recently
from
fce710d
to
1941005
Compare
This was referenced Nov 6, 2023
Closed
lukekarrys
force-pushed
the
lk/latest-npm
branch
2 times, most recently
from
0bc47d6
to
4c9486d
Compare
lukekarrys
force-pushed
the
lk/latest-npm
branch
from
4c9486d
to
2951271
Compare
lukekarrys
force-pushed
the
lk/latest-npm
branch
from
2951271
to
97e08d8
Compare
wraithgar
approved these changes
Nov 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains 4 commits which all contribute to allowing projects to use TypeScript, publish dual CJS/ESM, and use tap@18.
fix: use npx semver to better determine latest npm
This does a better job of allowing the latest compatible
npmversion to be installed. This is helpful as there were some gaps previously, and this allows us to bump smaller engines ranges and not have to worry about the wrong npm being installed.fix: always lint all js-ish extensions
The default lint script now will lint all JS extensions including
cjs,mjs, andts. This is written to all repos instead of based on a config because it is difficult to determine the file extensions being used in a project.feat: add typescript and esm support
If
typescript: trueis set then a number of changes are made including, checking for typescript deps, updating linting, usingtshyto do dual CJS/ESM, etcfix: remove tap 16 specific config when using tap 18
tap@18has some slightly different configs that we want to write.Closes #369
Closes #156