Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Ignore transient tap test directories #364

Merged
merged 4 commits into from Sep 15, 2023
Merged

fix: Ignore transient tap test directories #364

merged 4 commits into from Sep 15, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Sep 15, 2023

Running tests causes a lot of file churn. Although (usually) ephemeral, these files cause high CPU usage and can make developer tools difficult to use. These files also make linting fail.

Now the files will be ignored by git and by eslint.

References

Fixes #348
Fixes #359

This is a rebase of #350 since it had yet another conflict.

@wraithgar wraithgar requested a review from a team as a code owner September 15, 2023 18:01
@wraithgar wraithgar changed the title silent vicuna fix: Ignore transient tap test directories Sep 15, 2023
@wraithgar wraithgar enabled auto-merge (squash) September 15, 2023 18:03
@wraithgar wraithgar merged commit 29bf19d into main Sep 15, 2023
48 of 50 checks passed
@wraithgar wraithgar deleted the silent-vicuna branch September 15, 2023 18:04
@github-actions github-actions bot mentioned this pull request Sep 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] lint script broken [BUG] tap-testdir-* is not gitignored
3 participants