Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: install npm in CI based on node version #354

Merged
merged 1 commit into from Sep 12, 2023
Merged

fix: install npm in CI based on node version #354

merged 1 commit into from Sep 12, 2023

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Sep 12, 2023 •
edited

Fixes #353

This removes the npmSpec config in favor of installing an npm major based on the node version.

This will help us get more CI running npm@10 for older packages that only support npm@10 in some CI versions.

@lukekarrys lukekarrys requested a review from a team as a code owner September 12, 2023 17:22
wraithgar
wraithgar previously approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@wraithgar wraithgar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I sure wish we still had npmSpec as a ripcord but I don't think it's a problem today so it's not a blocker.

@lukekarrys lukekarrys merged commit 44123b8 into main Sep 12, 2023
23 checks passed
@lukekarrys lukekarrys deleted the lk/353 branch September 12, 2023 18:03
@github-actions github-actions bot mentioned this pull request Sep 12, 2023
Merged
@lukekarrys lukekarrys mentioned this pull request Sep 14, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

setup node should install best version of npm
2 participants
@lukekarrys @wraithgar