Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make settings file actually work #313

Merged
merged 2 commits into from
May 3, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
23 changes: 7 additions & 16 deletions .github/settings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,23 +13,14 @@ repository:
branches:
- name: main
protection:
required_pull_request_reviews:
required_pull_request_review_count: 1
dismiss_stale_reviews: true
require_code_owner_reviews: true
restrictions:
teams:
- "npm/cli-team"
enforce_admins: true
required_status_checks: null
- name: latest
protection:
enforce_admins: true
required_pull_request_reviews:
required_pull_request_review_count: 1
dismiss_stale_reviews: true
required_approving_review_count: 1
require_code_owner_reviews: true
require_last_push_approval: true
dismiss_stale_reviews: true
restrictions:
teams:
- "npm/cli-team"
enforce_admins: true
required_status_checks: null
apps: []
users: []
teams: [ "cli-team" ]
18 changes: 9 additions & 9 deletions lib/content/settings.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,16 +9,16 @@ repository:
enable_vulnerability_alerts: true

branches:
{{#each branches}}
- name: {{ . }}
- name: {{ defaultBranch }}
protection:
required_status_checks: null
enforce_admins: true
required_pull_request_reviews:
required_pull_request_review_count: 1
dismiss_stale_reviews: true
required_approving_review_count: 1
require_code_owner_reviews: true
require_last_push_approval: true
dismiss_stale_reviews: true
restrictions:
teams:
- "npm/cli-team"
enforce_admins: true
required_status_checks: null
{{/each}}
apps: []
users: []
teams: ["cli-team"]
69 changes: 21 additions & 48 deletions tap-snapshots/test/apply/source-snapshots.js.test.cjs
Original file line number Diff line number Diff line change
Expand Up @@ -180,26 +180,17 @@ repository:
branches:
- name: main
protection:
required_pull_request_reviews:
required_pull_request_review_count: 1
dismiss_stale_reviews: true
require_code_owner_reviews: true
restrictions:
teams:
- "npm/cli-team"
enforce_admins: true
required_status_checks: null
- name: latest
protection:
enforce_admins: true
required_pull_request_reviews:
required_pull_request_review_count: 1
dismiss_stale_reviews: true
required_approving_review_count: 1
require_code_owner_reviews: true
require_last_push_approval: true
dismiss_stale_reviews: true
restrictions:
teams:
- "npm/cli-team"
enforce_admins: true
required_status_checks: null
apps: []
users: []
teams: [ "cli-team" ]

.github/workflows/audit.yml
========================================
Expand Down Expand Up @@ -1625,26 +1616,17 @@ repository:
branches:
- name: main
protection:
required_pull_request_reviews:
required_pull_request_review_count: 1
dismiss_stale_reviews: true
require_code_owner_reviews: true
restrictions:
teams:
- "npm/cli-team"
enforce_admins: true
required_status_checks: null
- name: latest
protection:
enforce_admins: true
required_pull_request_reviews:
required_pull_request_review_count: 1
dismiss_stale_reviews: true
required_approving_review_count: 1
require_code_owner_reviews: true
require_last_push_approval: true
dismiss_stale_reviews: true
restrictions:
teams:
- "npm/cli-team"
enforce_admins: true
required_status_checks: null
apps: []
users: []
teams: [ "cli-team" ]

.github/workflows/audit.yml
========================================
Expand Down Expand Up @@ -3346,26 +3328,17 @@ repository:
branches:
- name: main
protection:
required_pull_request_reviews:
required_pull_request_review_count: 1
dismiss_stale_reviews: true
require_code_owner_reviews: true
restrictions:
teams:
- "npm/cli-team"
enforce_admins: true
required_status_checks: null
- name: latest
protection:
enforce_admins: true
required_pull_request_reviews:
required_pull_request_review_count: 1
dismiss_stale_reviews: true
required_approving_review_count: 1
require_code_owner_reviews: true
require_last_push_approval: true
dismiss_stale_reviews: true
restrictions:
teams:
- "npm/cli-team"
enforce_admins: true
required_status_checks: null
apps: []
users: []
teams: [ "cli-team" ]

.github/workflows/ci-a.yml
========================================
Expand Down