Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use a more portable means of spawning subshells #306

Merged
merged 1 commit into from Apr 26, 2023
Merged

fix: use a more portable means of spawning subshells #306

merged 1 commit into from Apr 26, 2023

Conversation

nlf
Copy link
Contributor

@nlf nlf commented Apr 26, 2023

the previous usage of backticks for subshells works in bash and zsh, but not fish. switching to the $() syntax works in all three shells

@nlf nlf requested a review from a team as a code owner April 26, 2023 18:45
@nlf nlf requested a review from fritzy April 26, 2023 18:45
@nlf nlf merged commit 1babe54 into main Apr 26, 2023
23 checks passed
@nlf nlf deleted the nlf/tweak-command-in-release-pr branch April 26, 2023 19:03
@github-actions github-actions bot mentioned this pull request Apr 26, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wraithgar wraithgar wraithgar approved these changes

@fritzy fritzy Awaiting requested review from fritzy fritzy is a code owner automatically assigned from npm/cli-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@nlf @wraithgar