Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: Bump isexe from 2.0.0 to 3.1.1 #105

Merged
merged 4 commits into from
Aug 29, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Aug 3, 2023

Bumps isexe from 2.0.0 to 3.1.1.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [isexe](https://github.com/isaacs/isexe) from 2.0.0 to 3.1.1.
- [Commits](isaacs/isexe@v2.0.0...v3.1.1)

---
updated-dependencies:
- dependency-name: isexe
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot requested a review from a team as a code owner August 3, 2023 03:06
@dependabot dependabot bot added the Dependencies Pull requests that update a dependency file label Aug 3, 2023
@wraithgar wraithgar force-pushed the dependabot/npm_and_yarn/main/isexe-3.1.1 branch from 998dddb to 1982c74 Compare August 7, 2023 15:39
BREAKING CHANGE: support for node 14 has been removed
@bpasero
Copy link

bpasero commented Aug 29, 2023

👍 , can this proceed and get released to a new version? We would like to pick it up in the VS Code git extension:

https://github.com/microsoft/vscode/blob/ebd67244fb2da33ab078bb2baa96106fda29f336/extensions/git/package.json#L3015

@wraithgar
Copy link
Member

@bpasero you're welcome to try to help dig in and find why isexe behaves differently in windows, making the tests fail.

Copy link

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wraithgar suggested a fix

test/index.js Outdated Show resolved Hide resolved
@wraithgar wraithgar force-pushed the dependabot/npm_and_yarn/main/isexe-3.1.1 branch from 915c497 to ba48d8a Compare August 29, 2023 15:46
@wraithgar wraithgar merged commit a5f1e8b into main Aug 29, 2023
17 checks passed
@wraithgar wraithgar deleted the dependabot/npm_and_yarn/main/isexe-3.1.1 branch August 29, 2023 18:13
@github-actions github-actions bot mentioned this pull request Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants