Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: better handling of whitespace (backport to v6) #591

Merged
merged 1 commit into from Jul 10, 2023

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys commented Jul 7, 2023

This is a backport of the following commits squashed to land on
release/v6:

Ref: #564

This is a backport of the following commits squashed to land on
`release/v6`:

- 717534e
- abdd93d
- cc6fde2
- 99d8287

Ref: #564

Co-authored-by: joaomoreno <mail@joaomoreno.com>
@lukekarrys lukekarrys requested a review from a team as a code owner July 7, 2023 22:52
@lukekarrys lukekarrys changed the title fix: better handling of whitespace fix: better handling of whitespace (backport to v6) Jul 7, 2023
@lukekarrys
Copy link
Contributor Author

@nicolo-ribaudo I was able to get the backport from v5 to land on v6 without much trouble. How does this look compared to what you did in your fork?

Copy link

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks very similar to my own backport 👍

@lukekarrys lukekarrys merged commit 928e56d into release/v6 Jul 10, 2023
8 checks passed
@lukekarrys lukekarrys deleted the lk/v6-backport branch July 10, 2023 19:07
@github-actions github-actions bot mentioned this pull request Jul 10, 2023
@Logan0112

This comment was marked as spam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants