fix: reuse comparators on subset #537
Merged
+6
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I comment here: #528 (comment)
The method of subset was creating comparators without needing for a specific ranges, perf:
After caching those comparators:
It's an improvement of about 13~14% for these cases.
benchmark.js
About memory
To test the memory usage, I used isitfast which still in beta but provide a useful way of measuring memory (ignore op/s):
After:
Is a reduction of 21%~26% in memory usage.
isitfast.js
References