Skip to content

Commit

Permalink
fix: reuse comparators on subset
Browse files Browse the repository at this point in the history
  • Loading branch information
H4ad committed Apr 6, 2023
1 parent da08e01 commit f7f3f4b
Showing 1 changed file with 6 additions and 3 deletions.
9 changes: 6 additions & 3 deletions ranges/subset.js
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,9 @@ const subset = (sub, dom, options = {}) => {
return true
}

const minimumVersionWithPreRelease = Object.freeze([new Comparator('>=0.0.0-0')]);

Check failure on line 71 in ranges/subset.js

View workflow job for this annotation

GitHub Actions / Lint

Extra semicolon
const minimumVersion = Object.freeze([new Comparator('>=0.0.0')]);

Check failure on line 72 in ranges/subset.js

View workflow job for this annotation

GitHub Actions / Lint

Extra semicolon

const simpleSubset = (sub, dom, options) => {
if (sub === dom) {
return true
Expand All @@ -77,17 +80,17 @@ const simpleSubset = (sub, dom, options) => {
if (dom.length === 1 && dom[0].semver === ANY) {
return true
} else if (options.includePrerelease) {
sub = [new Comparator('>=0.0.0-0')]
sub = minimumVersionWithPreRelease
} else {
sub = [new Comparator('>=0.0.0')]
sub = minimumVersion
}
}

if (dom.length === 1 && dom[0].semver === ANY) {
if (options.includePrerelease) {
return true
} else {
dom = [new Comparator('>=0.0.0')]
dom = minimumVersion
}
}

Expand Down

0 comments on commit f7f3f4b

Please sign in to comment.