fix: resolve override conflicts and apply correct versions #8089
Conversation
| // rawSpec can be undefined, so we need to use the fallback value of spec if it is. | ||
| let spec = npa(`${edge.name}@${edge.rawSpec || edge.spec}`) |
There was a problem hiding this comment.
I'm making an assumption here that we can fallback
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
…D' for edge override set inconsistencies
| @@ -2932,7 +3018,7 @@ t.test('overrides', (t) => { | |||
| ], | |||
| }) | |||
|
|
|||
| t.equal(original.canReplaceWith(badReplacement), false, 'different overrides fails') | |||
| t.equal(original.canReplaceWith(equivalentReplacement), true, 'different overrides passes') | |||
There was a problem hiding this comment.
behavior change, equivalent can now override
|
@jdalton I'm feeling pretty good about this. Any chance you guys have some capacity to take a look? |
|
Thanks to everyone who worked on this! Fingers crossed we can do a cli release today and this should be included in it. |
wraithgar
changed the title
|
Thank you @owlstronaut! Will sync these up with our wrapper. I'll report back if anything funky happens. |
|
Hey @owlstronaut @wraithgar, |
11.2.0 -> #8074 |
This PR is to help get #7025 over the line. The community member did a great job the fixes in - this'll be an attempt to get it over the line
References
Related:
#7025 #5850