Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rewrite powershell scripts to use PSScriptRoot #7422

Merged
merged 3 commits into from
Apr 29, 2024

Conversation

lukekarrys
Copy link
Contributor

@lukekarrys lukekarrys requested a review from a team as a code owner April 25, 2024 22:48
bin/npm.ps1 Outdated Show resolved Hide resolved
bin/npm.ps1 Show resolved Hide resolved
@lukekarrys
Copy link
Contributor Author

We have tests for these files, but out of caution I am not going to land this until I'm able to at least simulate "installing" these files and running them on my Windows machine.

@lukekarrys lukekarrys merged commit 5230647 into latest Apr 29, 2024
19 checks passed
@lukekarrys lukekarrys deleted the lk/powershell-fixes branch April 29, 2024 17:05
@github-actions github-actions bot mentioned this pull request Apr 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] npm ci fails on Windows with Node.js 22.0.0
2 participants