Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: backport benchmark, node PR, and smoke tests chores #6877

Merged
merged 6 commits into from
Oct 6, 2023

Conversation

lukekarrys
Copy link
Contributor

Verified

This commit was signed with the committer’s verified signature.
lukekarrys Luke Karrys
This is a fix to allow multiple Node PRs to be open.
Previously the script would attempt to edit an existing PR but
PRs to different branches were getting incorrectly edited.

Verified

This commit was signed with the committer’s verified signature.
lukekarrys Luke Karrys

Verified

This commit was signed with the committer’s verified signature.
lukekarrys Luke Karrys

Verified

This commit was signed with the committer’s verified signature.
lukekarrys Luke Karrys
This passes the token to the github-script action and now skips the PR workflow for forks in the if statement instead of while running the script

Verified

This commit was signed with the committer’s verified signature.
lukekarrys Luke Karrys

Verified

This commit was signed with the committer’s verified signature.
lukekarrys Luke Karrys
The proxy package is more spec compliant and works out-of-the-box
so we no longer have to pass --registry=PROXY to the tests.

The goal here is to make it simpler to help debug #6793.
@lukekarrys lukekarrys changed the title lk/v9 chores chore: backport benchmark, node PR, and smoke tests chores Oct 6, 2023
@lukekarrys lukekarrys marked this pull request as ready for review October 6, 2023 17:43
@lukekarrys lukekarrys requested a review from a team as a code owner October 6, 2023 17:43
@lukekarrys lukekarrys marked this pull request as draft October 6, 2023 17:47
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
@lukekarrys lukekarrys marked this pull request as ready for review October 6, 2023 20:53
@wraithgar
Copy link
Member

wraithgar commented Oct 6, 2023

The dependency is-core-module is getting bumped here with no deps entry.

#6814 landed in latest w/ the same conditions so this should be addressed if we do a deps update PR for v9

@lukekarrys lukekarrys merged commit e79f28f into release/v9 Oct 6, 2023
@lukekarrys lukekarrys deleted the lk/v9-chores branch October 6, 2023 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants