fix: ensure workspace links query parents correctly #6829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any way you can revert the linting changes? Restore the test to |
Carl-Foster
force-pushed
the
fix/query-child-workspace-dependencies
branch
from
628eb61
to
5df232e
Compare
|
Fixed up. |
wraithgar
approved these changes
Sep 27, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
hasParentquery handler does not handleArboristLink(s) correctly. This causes child workspaces to not return their dependencies when not in a direct child query.References
Fixes #6828
Not sure why the formatting got changed. I ran the linter and it seemed to do all this change.