fix: query with workspace descendents #6782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdehamer
commented
Sep 9, 2023
bdehamer
commented
Sep 9, 2023
bdehamer
force-pushed
the
bdehamer/bugfix-query-with-workspace
branch
5 times, most recently
from
87e5b86
to
4b7f558
Compare
bdehamer
changed the title
bdehamer
force-pushed
the
bdehamer/bugfix-query-with-workspace
branch
7 times, most recently
from
163af67
to
45889e1
Compare
bdehamer
commented
Sep 14, 2023
Fixes a query bug which omits some dependencies in scenarios where a workspace has a dependency on another workspace in the project. Signed-off-by: Brian DeHamer <bdehamer@github.com>
bdehamer
force-pushed
the
bdehamer/bugfix-query-with-workspace
branch
from
45889e1
to
24fa595
Compare
wraithgar
approved these changes
Sep 15, 2023
Merged
bdehamer
added a commit
that referenced
this pull request
Sep 15, 2023
Fixes a query bug which omits some dependencies in scenarios where a workspace has a dependency on another workspace in the project.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes npm/statusboard#703
In scenarios where one workspace has a dependency on another workspace,
querySelectorAllmay omit some child dependencies. This stems from the fact that the algorithm to find dependencies, starts at the leaf and tries to find a path (followingedgesIn) which leads back to the selected node. When workspaces are involved you can't reliably walk back up the dependency tree in this direction (ArboristNodes representing a workspace have noedgesIn).The proposed fix updates the
hasAscendantfunction to also follow thelinksIncollection when trying to find a path to the selected node.