Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gar/deps updates #6275

Merged
merged 16 commits into from
Mar 23, 2023
Merged

gar/deps updates #6275

merged 16 commits into from
Mar 23, 2023

Conversation

wraithgar
Copy link
Member

@wraithgar wraithgar commented Mar 20, 2023 •
edited

Lots of deps updates

@wraithgar wraithgar requested a review from a team as a code owner March 20, 2023 20:22
@wraithgar wraithgar requested review from fritzy and removed request for a team March 20, 2023 20:22
@npm-cli-bot
Copy link
Collaborator

npm-cli-bot commented Mar 21, 2023 •
edited

no statistically significant performance changes detected

timing results
app-large clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit		 show-version run-script
npm@9 43.670 ±2.80 15.435 ±0.05 14.280 ±0.06 17.083 ±0.56 2.730 ±0.04 2.763 ±0.01 2.147 ±0.02 10.045 ±0.17 2.156 ±0.00 3.322 ±0.18 0.465 ±0.00 0.479 ±0.00
#6275 39.134 ±6.90 15.625 ±0.19 14.618 ±0.01 17.197 ±0.91 2.752 ±0.11 2.731 ±0.02 2.123 ±0.02 10.227 ±0.01 2.205 ±0.07 3.262 ±0.00 0.505 ±0.03 0.489 ±0.00
app-medium clean lock-only cache-only cache-only
peer-deps		 modules-only no-lock no-cache no-modules no-clean no-clean
audit		 show-version run-script
npm@9 28.825 ±3.50 12.148 ±0.01 11.283 ±0.04 12.407 ±0.27 2.500 ±0.02 2.469 ±0.00 2.147 ±0.01 7.700 ±0.07 1.996 ±0.02 2.893 ±0.06 0.466 ±0.01 0.479 ±0.00
#6275 25.512 ±0.89 12.272 ±0.04 11.419 ±0.11 12.251 ±0.06 2.517 ±0.04 2.579 ±0.01 2.235 ±0.03 7.898 ±0.00 2.096 ±0.03 2.921 ±0.01 0.485 ±0.00 0.499 ±0.00

@bdehamer bdehamer mentioned this pull request Mar 21, 2023
Merged
@wraithgar wraithgar force-pushed the gar/deps-updates branch 6 times, most recently from 61dbd36 to 095fa3f Compare March 22, 2023 17:14
@wraithgar
fix: clean up man sorting
635433f 
glob doesn't sort and returns things in the os specific representation.
Also a lot of the edge cases here covered non-reality.  Our current man
setup already has all of the `npm-` prefixed things in `man1`.
nlf
nlf suggested changes Mar 23, 2023
View reviewed changes
lib/commands/help-search.js Show resolved Hide resolved
lib/commands/help.js Show resolved Hide resolved
@wraithgar wraithgar merged commit 6a4bcba into latest Mar 23, 2023
@wraithgar wraithgar deleted the gar/deps-updates branch March 23, 2023 16:35
@github-actions github-actions bot mentioned this pull request Mar 23, 2023
Merged
@npm-cli-bot npm-cli-bot mentioned this pull request Mar 30, 2023
Merged
@snyamathi snyamathi mentioned this pull request Apr 15, 2023
Closed
@github-actions github-actions bot mentioned this pull request Oct 6, 2023
Merged
@github-actions github-actions bot mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nlf nlf nlf approved these changes

@lukekarrys lukekarrys lukekarrys approved these changes

@fritzy fritzy Awaiting requested review from fritzy fritzy is a code owner automatically assigned from npm/cli-team

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@wraithgar @npm-cli-bot @nlf @lukekarrys