Decouple read buffer from connector #5462
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5454 I had to make a fairly unappealing test as I needed a connector to be able to use the column stream.
Additionally we had some unresolved uglyness around LongRunningConnection/commandscope after doing #5123.
So after we recently discussed improving localized recovery in #5440 I decided it was time for me to understand the cancellation mechanisms in place more deeply and improve separation.
This is one step towards recovering from timeouts/OCEs in a more localized fashion as all control is now situated in the connector. Future work would be to allow Cancel to withhold breaking the connection and instead just cancel the current operation.