Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix EndRead throwing exceptions when a stream is active #5454

Merged
merged 2 commits into from Nov 28, 2023
Merged

Fix EndRead throwing exceptions when a stream is active #5454

merged 2 commits into from Nov 28, 2023

Conversation

NinoFloris
Copy link
Member

Check whether a stream is active before throwing unconsumed exception.

This does not affect GetStream() as we're implementing that intrinsically (i.e. without converters, so no Start/EndRead).

Fixes #5450

@NinoFloris NinoFloris mentioned this pull request Nov 24, 2023
Closed
@NinoFloris NinoFloris mentioned this pull request Nov 27, 2023
Draft
roji
roji approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Npgsql/Internal/PgReader.cs Show resolved Hide resolved
@NinoFloris NinoFloris enabled auto-merge (squash) November 28, 2023 23:26
@NinoFloris NinoFloris merged commit 42ea28f into main Nov 28, 2023
16 checks passed
@NinoFloris NinoFloris deleted the fix-endread-stream-active branch November 28, 2023 23:32
NinoFloris added a commit that referenced this pull request Nov 28, 2023
@NinoFloris
Fix EndRead throwing exceptions when a stream is active (#5454)
1d070a5 
Fixes #5450

(cherry picked from commit 42ea28f)
@NinoFloris
Copy link
Member Author

Backported to 8.0.1 via 1d070a5

@NinoFloris NinoFloris mentioned this pull request Dec 6, 2023
Merged
JonasWestman pushed a commit to monitor-erp/npgsql that referenced this pull request Dec 20, 2023
@NinoFloris @JonasWestman
Fix EndRead throwing exceptions when a stream is active (npgsql#5454)
73ff7ad 
Fixes npgsql#5450

(cherry picked from commit 42ea28f)
Signed-off-by: monjowe <jonas.westman@monitor.se>
JonasWestman pushed a commit to monitor-erp/npgsql that referenced this pull request Dec 21, 2023
@NinoFloris @JonasWestman
Fix EndRead throwing exceptions when a stream is active (npgsql#5454)
e26dbee 
Fixes npgsql#5450

(cherry picked from commit 42ea28f)
Signed-off-by: monjowe <jonas.westman@monitor.se>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

@vonzshik vonzshik Awaiting requested review from vonzshik vonzshik is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PgReader.GetTextReader with size > 65536 fails
2 participants
@NinoFloris @roji