bench: add websockets #3203
Draft
bench: add websockets #3203
+380
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3203 +/- ##
=======================================
Coverage 94.17% 94.17%
=======================================
Files 90 90
Lines 24432 24432
=======================================
Hits 23009 23009
Misses 1423 1423 ☔ View full report in Codecov by Sentry. |
metcoder95
approved these changes
May 5, 2024
|
To have reliable benchmarks you should use two processes, one for the server and one for the client and ensure that the server is faster than the client, otherwise you might end up benchmarking the server instead of the client. See the discussion in nodejs/node#50586. |
KhafraDev
requested changes
May 5, 2024
tsctx
force-pushed
the
bench/add-websockets
branch
from
7af0bac
to
7ef0e3a
Compare
tsctx
force-pushed
the
bench/add-websockets
branch
from
53de211
to
f5204cf
Compare
tsctx
force-pushed
the
bench/add-websockets
branch
from
f5204cf
to
370f8cb
Compare
|
Could I help with that pr somehow @tsctx ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #3201