Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: onConnect types #3116

Merged
merged 3 commits into from
Apr 14, 2024
Merged

fix: onConnect types #3116

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3fedbd7
fix: onConnect types
ronag Apr 14, 2024
0f900cc
Update types/dispatcher.d.ts
ronag Apr 14, 2024
edbdc3c
Update dispatcher.d.ts
ronag Apr 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion types/dispatcher.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ declare namespace Dispatcher {
export type StreamFactory = (data: StreamFactoryData) => Writable;
export interface DispatchHandlers {
/** Invoked before request is dispatched on socket. May be invoked multiple times when a request is retried when the request at the head of the pipeline fails. */
onConnect?(abort: () => void): void;
onConnect?(abort: (err: Error) => void): void;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isnt the error optional?

ronag marked this conversation as resolved.
Show resolved Hide resolved
/** Invoked when an error has occurred. */
onError?(err: Error): void;
/** Invoked when request is upgraded either due to a `Upgrade` header or `CONNECT` method. */
Expand Down