Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(H2 Client): bind stream 'data' listener only after received 'response' event #2985

Merged
merged 6 commits into from
Mar 25, 2024
Merged

fix(H2 Client): bind stream 'data' listener only after received 'response' event #2985

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
cd2eaf4
fix(fetch): pause stream if data is received before headers in HTTP/2
stefanoaga Mar 22, 2024
cf6a5ea
Revert "fix(fetch): pause stream if data is received before headers i…
st3ffgv4 Mar 23, 2024
9219ee3
fix(H2 Client): pause stream if response data is sent before response…
st3ffgv4 Mar 23, 2024
fb8d568
Revert "fix(H2 Client): pause stream if response data is sent before …
st3ffgv4 Mar 24, 2024
6c661b3
fix(H2 Client): bind stream 'data' listener once 'response' is triggered
st3ffgv4 Mar 24, 2024
54cd840
Merge branch 'nodejs:main' into main
st3ffgv4 Mar 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions lib/dispatcher/client-h2.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -394,6 +394,12 @@ function writeH2 (client, request) {
if (request.onHeaders(Number(statusCode), realHeaders, stream.resume.bind(stream), '') === false) {
stream.pause()
}

stream.on('data', (chunk) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the link to the issue as comment?

if (request.onData(chunk) === false) {
stream.pause()
}
})
})

stream.once('end', () => {
Expand All @@ -418,12 +424,6 @@ function writeH2 (client, request) {
util.destroy(stream, err)
})

stream.on('data', (chunk) => {
if (request.onData(chunk) === false) {
stream.pause()
}
})

stream.once('close', () => {
session[kOpenStreams] -= 1
// TODO(HTTP/2): unref only if current streams count is 0
Expand Down