Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: port autoselectfamily.js tests to node:test runner #2570

Merged
merged 5 commits into from
Jan 3, 2024
Merged

feat: port autoselectfamily.js tests to node:test runner #2570

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
73dd39f
Move utils to `/test/utils`
sosukesuzuki Dec 30, 2023
a291dcb
Use `p.completed`
sosukesuzuki Dec 30, 2023
60e19c0
Make `ttype` return `boolean`
sosukesuzuki Dec 31, 2023
087c60b
port `autoselectfamily.js` to `node:test` runner
sosukesuzuki Dec 31, 2023
08f162d
Remove `node-test` helpers
sosukesuzuki Jan 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
59 changes: 34 additions & 25 deletions test/autoselectfamily.js → test/node-test/autoselectfamily.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,13 @@
'use strict'

const { test, skip } = require('tap')
const { test, skip } = require('node:test')
const dgram = require('dgram')
const { Resolver } = require('dns')
const dnsPacket = require('dns-packet')
const { createServer } = require('http')
const { Client, Agent, request } = require('..')
const { nodeHasAutoSelectFamily } = require('../lib/core/util')
const { Client, Agent, request } = require('../..')
const { nodeHasAutoSelectFamily } = require('../../lib/core/util')
const { tspl } = require('@matteo.collina/tspl')

/*
* IMPORTANT
Expand Down Expand Up @@ -67,15 +68,15 @@ function createDnsServer (ipv6Addr, ipv4Addr, cb) {
})
}

test('with autoSelectFamily enable the request succeeds when using request', (t) => {
t.plan(3)
test('with autoSelectFamily enable the request succeeds when using request', async (t) => {
const p = tspl(t, { plan: 3 })

createDnsServer('::1', '127.0.0.1', function (_, { dnsServer, lookup }) {
const server = createServer((req, res) => {
res.end('hello')
})

t.teardown(() => {
t.after(() => {
server.close()
dnsServer.close()
})
Expand All @@ -88,7 +89,7 @@ test('with autoSelectFamily enable the request succeeds when using request', (t)
method: 'GET',
dispatcher: agent
}, (err, { statusCode, body }) => {
t.error(err)
p.ifError(err)

let response = Buffer.alloc(0)

Expand All @@ -97,37 +98,39 @@ test('with autoSelectFamily enable the request succeeds when using request', (t)
})

body.on('end', () => {
t.strictSame(statusCode, 200)
t.strictSame(response.toString('utf-8'), 'hello')
p.strictEqual(statusCode, 200)
p.strictEqual(response.toString('utf-8'), 'hello')
})
})
})
})

await p.completed
})

test('with autoSelectFamily enable the request succeeds when using a client', (t) => {
t.plan(3)
test('with autoSelectFamily enable the request succeeds when using a client', async (t) => {
const p = tspl(t, { plan: 3 })

createDnsServer('::1', '127.0.0.1', function (_, { dnsServer, lookup }) {
const server = createServer((req, res) => {
res.end('hello')
})

t.teardown(() => {
t.after(() => {
server.close()
dnsServer.close()
})

server.listen(0, '127.0.0.1', () => {
const client = new Client(`http://example.org:${server.address().port}`, { connect: { lookup }, autoSelectFamily: true })

t.teardown(client.destroy.bind(client))
t.after(client.destroy.bind(client))

client.request({
path: '/',
method: 'GET'
}, (err, { statusCode, body }) => {
t.error(err)
p.ifError(err)

let response = Buffer.alloc(0)

Expand All @@ -136,23 +139,25 @@ test('with autoSelectFamily enable the request succeeds when using a client', (t
})

body.on('end', () => {
t.strictSame(statusCode, 200)
t.strictSame(response.toString('utf-8'), 'hello')
p.strictEqual(statusCode, 200)
p.strictEqual(response.toString('utf-8'), 'hello')
})
})
})
})

await p.completed
})

test('with autoSelectFamily disabled the request fails when using request', (t) => {
t.plan(1)
test('with autoSelectFamily disabled the request fails when using request', async (t) => {
const p = tspl(t, { plan: 1 })

createDnsServer('::1', '127.0.0.1', function (_, { dnsServer, lookup }) {
const server = createServer((req, res) => {
res.end('hello')
})

t.teardown(() => {
t.after(() => {
server.close()
dnsServer.close()
})
Expand All @@ -164,35 +169,39 @@ test('with autoSelectFamily disabled the request fails when using request', (t)
method: 'GET',
dispatcher: agent
}, (err, { statusCode, body }) => {
t.ok(['ECONNREFUSED', 'EAFNOSUPPORT'].includes(err.code))
p.ok(['ECONNREFUSED', 'EAFNOSUPPORT'].includes(err.code))
})
})
})

await p.completed
})

test('with autoSelectFamily disabled the request fails when using a client', (t) => {
t.plan(1)
test('with autoSelectFamily disabled the request fails when using a client', async (t) => {
const p = tspl(t, { plan: 1 })

createDnsServer('::1', '127.0.0.1', function (_, { dnsServer, lookup }) {
const server = createServer((req, res) => {
res.end('hello')
})

t.teardown(() => {
t.after(() => {
server.close()
dnsServer.close()
})

server.listen(0, '127.0.0.1', () => {
const client = new Client(`http://example.org:${server.address().port}`, { connect: { lookup, autoSelectFamily: false } })
t.teardown(client.destroy.bind(client))
t.after(client.destroy.bind(client))

client.request({
path: '/',
method: 'GET'
}, (err, { statusCode, body }) => {
t.ok(['ECONNREFUSED', 'EAFNOSUPPORT'].includes(err.code))
p.ok(['ECONNREFUSED', 'EAFNOSUPPORT'].includes(err.code))
})
})
})

await p.completed
})