Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clear all timeout on destroy and close #2535

Merged
merged 1 commit into from
Dec 23, 2023
Merged

Clear all timeout on destroy and close #2535

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions lib/agent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,9 @@ class Agent extends DispatcherBase {
async [kClose] () {
const closePromises = []
for (const client of this[kClients].values()) {
if (client[kDeleteScheduled]) {
clearTimeout(client[kDeleteScheduled])
}
closePromises.push(client.close())
}
this[kClients].clear()
Expand All @@ -140,6 +143,9 @@ class Agent extends DispatcherBase {
async [kDestroy] (err) {
const destroyPromises = []
for (const client of this[kClients].values()) {
if (client[kDeleteScheduled]) {
clearTimeout(client[kDeleteScheduled])
}
destroyPromises.push(client.destroy(err))
}
this[kClients].clear()
Expand Down