Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf: Improve normalizeMethod #2456

Merged
merged 9 commits into from
Nov 26, 2023
Merged

perf: Improve normalizeMethod #2456

Changes from 7 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ef71748
perf: Improve `normalizeMethod`
tsctx Nov 25, 2023
43ec051
remove comment
tsctx Nov 25, 2023
41c1e74
test: add
tsctx Nov 25, 2023
3a37e7b
test: remove
tsctx Nov 25, 2023
aca32fe
perf: use Map
tsctx Nov 25, 2023
2206fa2
Merge branch 'nodejs:main' into perf/improve-normalize-method
tsctx Nov 25, 2023
49677c7
Revert "perf: use Map"
tsctx Nov 25, 2023
63bc8c4
Revert "test: remove"
tsctx Nov 25, 2023
fc8f94b
perf: direct reference
tsctx Nov 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
27 changes: 23 additions & 4 deletions lib/fetch/util.js
View file
Open in desktop
Expand Up @@ -698,11 +698,30 @@ function isCancelled (fetchParams) {
fetchParams.controller.state === 'terminated'
}

// https://fetch.spec.whatwg.org/#concept-method-normalize
const normalizeMethodRecord = {
delete: 'DELETE',
DELETE: 'DELETE',
get: 'GET',
GET: 'GET',
head: 'HEAD',
HEAD: 'HEAD',
options: 'OPTIONS',
OPTIONS: 'OPTIONS',
post: 'POST',
POST: 'POST',
put: 'PUT',
PUT: 'PUT'
}

// Note: object prototypes should not be able to be referenced. e.g. `Object#hasOwnProperty`.
Object.setPrototypeOf(normalizeMethodRecord, null)
tsctx marked this conversation as resolved.
Show resolved Hide resolved

/**
* @see https://fetch.spec.whatwg.org/#concept-method-normalize
* @param {string} method
*/
function normalizeMethod (method) {
return /^(DELETE|GET|HEAD|OPTIONS|POST|PUT)$/i.test(method)
? method.toUpperCase()
: method
return normalizeMethodRecord[method] ?? normalizeMethodRecord[method.toLowerCase()] ?? method
}

// https://infra.spec.whatwg.org/#serialize-a-javascript-value-to-a-json-string
Expand Down