Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: add value argument to has and delete methods #47885

Merged
merged 13 commits into from
May 14, 2023
Merged

url: add value argument to has and delete methods #47885

merged 13 commits into from
May 14, 2023

Commits on May 8, 2023

  1. url: add value argument to has and delete methods 

    The change aims to add value argument to two methods of URLSearchParams
class i.e the has method and the delete method. For has method, if
value argument is provided, then use it to check for presence. For
delete method, if value argument provided, use it to delete.

Fixes: nodejs#47883
    @sankalp1999
    sankalp1999 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    7d99ffc View commit details
    Browse the repository at this point in the history

  2. url: add wpt tests

    @sankalp1999
    sankalp1999 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    ecf95b5 View commit details
    Browse the repository at this point in the history

  3. url: ran linter

    @sankalp1999
    sankalp1999 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    5031f58 View commit details
    Browse the repository at this point in the history

  4. fixup! refactor delete method one loop into two for better readability

    @sankalp1999
    sankalp1999 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    f1845e3 View commit details
    Browse the repository at this point in the history

  5. url: refactor has method

    @sankalp1999
    sankalp1999 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    2846704 View commit details
    Browse the repository at this point in the history

  6. url: correction in hsa method, exact key-value tuple search

    @sankalp1999
    sankalp1999 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    a0522c8 View commit details
    Browse the repository at this point in the history

  7. doc: update has method and delete method

    @sankalp1999
    sankalp1999 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    3c1521f View commit details
    Browse the repository at this point in the history

  8. fixup! add changes in doc and refactor urlsearchparam-has

    @sankalp1999
    sankalp1999 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    e66fe1e View commit details
    Browse the repository at this point in the history

  9. fixup! add default arg as undefined to value

    @sankalp1999
    sankalp1999 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    68624b3 View commit details
    Browse the repository at this point in the history

  10. tools: fix to accommodate base as null, benchmark test fixed

    @sankalp1999
    sankalp1999 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    29c316c View commit details
    Browse the repository at this point in the history

  11. fixup! refactor delete method and minor correction in docs

    @sankalp1999
    sankalp1999 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    9126a64 View commit details
    Browse the repository at this point in the history

  12. url: refactor conditional statements in the loop

    @sankalp1999
    sankalp1999 committed May 8, 2023
    Configuration menu
    Copy the full SHA
    3b19423 View commit details
    Browse the repository at this point in the history

Commits on May 14, 2023

  1. fixup! minor changes in docs

    @sankalp1999
    sankalp1999 committed May 14, 2023
    Configuration menu
    Copy the full SHA
    fb0e57d View commit details
    Browse the repository at this point in the history