Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor december #801

Merged
merged 11 commits into from Dec 27, 2021
Merged

Refactor december #801

merged 11 commits into from Dec 27, 2021

Conversation

GrosSacASac
Copy link
Contributor

No description provided.

@GrosSacASac GrosSacASac merged commit e19a4cf into master Dec 27, 2021
@GrosSacASac GrosSacASac deleted the refactor-december branch December 27, 2021 23:27
@tunnckoCore
Copy link
Member

@GrosSacASac

  1. Plugins should return, plus this pluginResults event is useful for debugging or whatever. Plus it encourages not touching the this that much (by the plugin creators). Potential breaking change inside the v2/v3 for some custom plugin user or whatever.
  2. old code as comments (use git) - code comments is exactly that 😆 , "using git" instead of Github or other social collab platform. OK, but just saying.

Anyway, thanks.

I was here after New Year, but I didn't seen these few things.

@GrosSacASac
Copy link
Contributor Author

some plugins did not return anything, that is why, I attempted to make things more consistent

@GrosSacASac
Copy link
Contributor Author

#820

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants