Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

return raw post rst when rendering fails #338

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

geotre
Copy link

@geotre geotre commented Jan 17, 2023

This PR introduces a simple change to show the raw RST text when a post fails to render (as discussed in #330). This should improve the experience when reading older threads where the issue is more prevalent, and improve visibility with search engines that can now pick up the original post content instead of the error message. It's been suggested that recent improvements to the RST parser will reduce the amount of these problematic posts as well.

I have used the content of the first post from this thread for testing.

Before:
image
After:
image

I've also tested that embedding the raw post does not allow for js injection.

@geotre
Copy link
Author

geotre commented Jan 18, 2023

CI fail is from a network error, unrelated to the changes

@ringabout ringabout closed this Jan 19, 2023
@ringabout ringabout reopened this Jan 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants