-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace per-method packages with the main lodash
package.
#4005
Conversation
Status
|
Opened #4006 to track updates for other per-method packages. |
@garg3133 isn't it possible to just upgrade the lodash.pick? if we opt for adding the entire lodash as a dependency than we should also remove the other |
@beatfactor Okay, I'll try to replace other per-method packages as well. |
@beatfactor I had to revert (Tests are passing within usual time after reverting that change.) |
lodash.pick
with main lodash
package.lodash
package.
The issue with Even if we upgrade |
Starting with v4, |
Can we backport this to version 2.6? That would be very helpful to get rid of the vulnerability in |
As this page states, use of the per-method lodash packages is discouraged: https://lodash.com/per-method-packages and these packages are no longer updated. So, we should replace all the per-method lodash packages with just the main
lodash
package.This PR does so for the
lodash.pick
package only for now to fix the security vulnerability in that package, so that we can put the fix in the next planned Nightwatch release.For the other similar per-method packages, we can replace them with
lodash
afterwards, as these upgrades may require some more attention to ensure we don't end up breaking anything.Fixes: #4003