Move log related commands to .logs namespaces.
#3796
Merged
+731
−82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status
|
garg3133
force-pushed
the
logs-namespace
branch
2 times, most recently
from
37c7e08 to
2103c3b
Compare
garg3133
changed the title
.logs namespaces.
swrdfish
approved these changes
Jul 11, 2023
|
These changes are also dependent on #3794 ? |
|
This PR is ready now. |
beatfactor
reviewed
Jul 19, 2023
| @@ -0,0 +1,54 @@ | |||
| const ClientCommand = require('../_base-command.js'); | |||
There was a problem hiding this comment.
I'm thinking that it would be better to name this and the other session log commands with using "session", as in getSessionLog, getSessionLogTypes, isSessionLogAvailable
|
@beatfactor I made the requested changes. |
Great, @AutomatedTester does this look ok to you, meaning the session log command names? |
|
Yes, this looks good. |
beatfactor
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New
logsnamespace:.logs.getSessionLog().logs.getSessionLogType().logs.isSessionLogAvailable().logs.captureBrowserConsoleLogs()(also available as.captureBrowserConsoleLogs()).logs.captureBrowserExceptions()(also available ascaptureBrowserExceptions())Deprecated commands:
.getLog()-- In favour of.logs.getSessionLog().getLogTypes()-- In favour of.logs.getSessionLogTypes().isLogAvailable()-- In favour of.logs.isSessionLogAvailable().sessionLog()-- In favour of.logs.getSessionLog().sessionLogTypes()-- In favour of.logs.getSessionLogTypes()TODO: