Store configuration and ServerPool on the app #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I need to rebase this to resolve the conflicts with blackening the code in #81. |
gmacon
force-pushed
the
issue-40-state-on-context
branch
from
2682858
to
e8e1d6b
Compare
|
OK, I've rebased this to resolve the formatting conflicts. |
HeMan
requested changes
Feb 24, 2020
gmacon
force-pushed
the
issue-40-state-on-context
branch
from
e8e1d6b
to
50e9469
Compare
|
I tripped over psf/black#1202. |
HeMan
approved these changes
Mar 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the second PR addressing #40. The configuration is now always read from the current app. While working on this, I realized that the ServerPool is more like configuration that state since it doesn't hold on to open connections. (i.e. it isn't a connection pool). I therefore stored it on the app, too.