Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1.8.8 #256

Merged
merged 116 commits into from Oct 20, 2023
Merged

v1.8.8 #256

merged 116 commits into from Oct 20, 2023

Commits on May 18, 2020

  1. Move all Wasm related code into ws_js.go

    This way we don't pollute the directory tree.
    nhooyr committed May 18, 2020
    Configuration menu
    Copy the full SHA
    b453d3e View commit details
    Browse the repository at this point in the history
  2. Disable compression by default

    Closes #220 and #230
    nhooyr committed May 18, 2020
    Configuration menu
    Copy the full SHA
    17cf0fe View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    de8e29b View commit details
    Browse the repository at this point in the history
  4. Add ping example

    Closes #227
    nhooyr committed May 18, 2020
    Configuration menu
    Copy the full SHA
    1695216 View commit details
    Browse the repository at this point in the history
  5. Make SetDeadline on NetConn not always close Conn

    NetConn has to close the connection to interrupt in progress reads
    and writes. However, it can block reads and writes that occur
    after the deadline instead of closing the connection.
    
    Closes #228
    nhooyr committed May 18, 2020
    Configuration menu
    Copy the full SHA
    0a61ffe View commit details
    Browse the repository at this point in the history

Commits on May 19, 2020

  1. Merge pull request #240 from nhooyr/restructure

    Disable compression by default and switch to stdlib compress
    nhooyr committed May 19, 2020
    Configuration menu
    Copy the full SHA
    aa4d85f View commit details
    Browse the repository at this point in the history

Commits on Jul 4, 2020

  1. ci/fmt.sh: Cleanup

    nhooyr committed Jul 4, 2020
    Configuration menu
    Copy the full SHA
    15a1523 View commit details
    Browse the repository at this point in the history

Commits on Jul 5, 2020

  1. netconn.go: Prevent timer leakage (#255)

    Closes #243
    nhooyr committed Jul 5, 2020
    Configuration menu
    Copy the full SHA
    493ebbe View commit details
    Browse the repository at this point in the history
  2. write.go: Fix deadlock in writeFrame (#253)

    Closes #248
    
    Luckily, due to the 5s timeout on the close handshake, this would have
    had very minimal effects on anyone in production.
    nhooyr committed Jul 5, 2020
    Configuration menu
    Copy the full SHA
    897a573 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2020

  1. Configuration menu
    Copy the full SHA
    fdc4079 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2021

  1. Merge branch 'master' into merge-master

    There were a few PRs merged into the master branch that were then not
    merged into the dev branch. This branch merges those changes in cleanly.
    
    - #261
    - #266
    - #273
    nhooyr committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    06beb14 View commit details
    Browse the repository at this point in the history
  2. Fix incorrect &*var clones

    Thank you @icholy for identifying these in
    #259 (comment)
    nhooyr committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    fe1020d View commit details
    Browse the repository at this point in the history
  3. ci/test.sh: Work with BSD sed

    nhooyr committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    e4fee52 View commit details
    Browse the repository at this point in the history
  4. Merge pull request #277 from nhooyr/merge-master

    Merge master into dev
    nhooyr committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    a8e475c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    3b20a49 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    29f527b View commit details
    Browse the repository at this point in the history
  7. Document context expirations wart

    Closes #242
    nhooyr committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    085d46c View commit details
    Browse the repository at this point in the history
  8. netconn: Disable read limit on WebSocket

    Closes #245
    nhooyr committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    ea87744 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    11af7f8 View commit details
    Browse the repository at this point in the history
  10. Merge pull request #254 from nhooyr/netconn-readlimit

    netconn.go: Disable read limit on WebSocket
    nhooyr committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    642a013 View commit details
    Browse the repository at this point in the history
  11. netconn.go: Cleanup contexts on close

    Updates #255
    nhooyr committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    482f584 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    29251d0 View commit details
    Browse the repository at this point in the history
  13. Fix formatting

    nhooyr committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    7c0c047 View commit details
    Browse the repository at this point in the history
  14. README.md: Update coverage

    nhooyr committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    6840778 View commit details
    Browse the repository at this point in the history
  15. wasm: Add dial timeout test

    nhooyr committed Jan 9, 2021
    Configuration menu
    Copy the full SHA
    65dfbdd View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Fix dial panic when ctx is nil

    When the ctx is nil, http.NewRequestWithContext returns a "net/http:
    nil Context" error and a nil request. In this case, the dial function
    panics because it assumes the req is never nil. This checks the
    returning error and returns it, so that callers get an error instead
    of a panic in that scenario.
    guseggert committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    7fd6136 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2023

  1. Configuration menu
    Copy the full SHA
    e2bb5be View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2023

  1. Update err message when dial ctx is nil

    Co-authored-by: Anmol Sethi <hi@nhooyr.io>
    guseggert and nhooyr committed Mar 7, 2023
    Configuration menu
    Copy the full SHA
    54809d6 View commit details
    Browse the repository at this point in the history

Commits on Oct 10, 2023

  1. autobahn_test: Use docker to avoid issues with python2 EOL

    Also ran gofmt on everything. Thanks again @paralin. #334
    
    Co-authored-by: Christian Stewart <christian@paral.in>
    nhooyr and paralin committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    6ead6aa View commit details
    Browse the repository at this point in the history
  2. Fix DOS attack from malicious pongs

    Cherry picked from master at 129d303
    nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7c87cb5 View commit details
    Browse the repository at this point in the history
  3. Fix grammar (#295)

    Co-authored-by: lazypassion <25536767+lazypassion@users.noreply.github.com>
    2 people authored and nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    b8f6512 View commit details
    Browse the repository at this point in the history
  4. README.md: Add note

    nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9e84c89 View commit details
    Browse the repository at this point in the history
  5. REAME: Update note

    nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    de6965b View commit details
    Browse the repository at this point in the history
  6. README: Further update

    nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    9e7b1d5 View commit details
    Browse the repository at this point in the history
  7. Merge branch 'master' into dev

    nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    7a37b6a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    5dd228a View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    b9a4d42 View commit details
    Browse the repository at this point in the history
  10. .github: Delete CODEOWNERS

    nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    a374f19 View commit details
    Browse the repository at this point in the history
  11. ci/container: Fix for newer Go

    nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    c45cd4c View commit details
    Browse the repository at this point in the history
  12. ci: Fixes

    Credits to @maggie44 for making me add staticcheck.
    See #407
    
    Co-authored-by: maggie0002 <64841595+maggie0002@users.noreply.github.com>
    nhooyr and maggie44 committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    118ea68 View commit details
    Browse the repository at this point in the history
  13. Update Go module version to 1.18

    Fixes #359
    Jacalz authored and nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    8d3d892 View commit details
    Browse the repository at this point in the history
  14. go.mod: Regenerate

    nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4188bcf View commit details
    Browse the repository at this point in the history
  15. ci.yml: Fix

    nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    1c90f47 View commit details
    Browse the repository at this point in the history
  16. go.mod: Upgrade to Go 1.19

    nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    2a5a566 View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    e1e65ad View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    75bf907 View commit details
    Browse the repository at this point in the history
  19. Merge pull request #371 from keystroke3/master

    Migrate from deprecated `io/ioutil`
    nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    91423a9 View commit details
    Browse the repository at this point in the history
  20. conn_test: Remove ioutil

    nhooyr committed Oct 10, 2023
    Configuration menu
    Copy the full SHA
    4ab2f54 View commit details
    Browse the repository at this point in the history

Commits on Oct 13, 2023

  1. Use net.ErrClosed

    Go 1.16 has introduced net.ErrClosed, which should be returned/wrapped when an
    I/O call is performed on a network connection which has already been closed.
    This is useful to avoid cluttering logs with messages like "failed to close
    WebSocket: already wrote close".
    
    Closes: #286
    emersion authored and nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    e9d0881 View commit details
    Browse the repository at this point in the history
  2. Merge pull request #303 from emersion/err-closed

    Use net.ErrClosed
    nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    7ce08e9 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #365 from guseggert/master

    Fix dial panic when ctx is nil
    nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    693fac9 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e305027 View commit details
    Browse the repository at this point in the history
  5. wspb: Remove

    The library we're currently using for protobufs is deprecated. Doesn't belong in the library core
    anyway.
    
    Closes #311
    Updates #297
    nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    ac38512 View commit details
    Browse the repository at this point in the history
  6. close_goXXX.go: fmt

    nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    9b5a15b View commit details
    Browse the repository at this point in the history
  7. lint.sh: Pass

    nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    a633a10 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    3f26c9f View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    f7bed7c View commit details
    Browse the repository at this point in the history
  10. Merge pull request #336 from bendiscz/client-host-override

    Extend DialOptions to allow Host header override
    nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    2f44d4e View commit details
    Browse the repository at this point in the history
  11. wsjson: fmt

    nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    9873274 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fecf26c View commit details
    Browse the repository at this point in the history
  13. Merge pull request #299 from photostorm/net-addr

    Returns real remote and local address instead mocked
    nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    61942a4 View commit details
    Browse the repository at this point in the history
  14. internal/util: golint

    nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    5793e7d View commit details
    Browse the repository at this point in the history
  15. Configuration menu
    Copy the full SHA
    2598ea2 View commit details
    Browse the repository at this point in the history
  16. dial.go: Use timeout on HTTPClient properly

    Closes #341
    nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    b4b86b9 View commit details
    Browse the repository at this point in the history
  17. conn: Add noCopy

    Closes #349
    nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    a6b9464 View commit details
    Browse the repository at this point in the history
  18. ci/bench.sh: Add

    nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    4e15d75 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    a02cbef View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    81afa8a View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    136f954 View commit details
    Browse the repository at this point in the history
  22. Configuration menu
    Copy the full SHA
    2291d83 View commit details
    Browse the repository at this point in the history
  23. Server selects first acceptable compression offer

    Unacceptable offers are declined without rejecting the request.
    abursavich authored and nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    711aa3f View commit details
    Browse the repository at this point in the history
  24. Remove x-webkit-deflate-frame dead code

    abursavich authored and nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    d6b342b View commit details
    Browse the repository at this point in the history
  25. Merge pull request #258 from abursavich/compression

    Make compression negotiation more lenient
    nhooyr committed Oct 13, 2023
    Configuration menu
    Copy the full SHA
    97d7f90 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    a975390 View commit details
    Browse the repository at this point in the history

Commits on Oct 14, 2023

  1. write: Zero alloc writes with Writer

    Closes #354
    nhooyr committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    1dbc141 View commit details
    Browse the repository at this point in the history
  2. close: Implement CloseNow

    Closes #384
    nhooyr committed Oct 14, 2023
    Configuration menu
    Copy the full SHA
    a94999f View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2023

  1. Configuration menu
    Copy the full SHA
    e314da6 View commit details
    Browse the repository at this point in the history

Commits on Oct 19, 2023

  1. dial_test: Add TestDialViaProxy

    For #395
    
    Somehow currently reproduces #391...
    
    Debugging still.
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    249edb2 View commit details
    Browse the repository at this point in the history
  2. TestDialViaProxy: Fix bug in forward proxy

    Closes #395
    
    Confirmed library works correctly with a working forward proxy.
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    818579b View commit details
    Browse the repository at this point in the history
  3. ci: Add dev to daily

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    20b8838 View commit details
    Browse the repository at this point in the history
  4. accept.go: Comment typo

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    591ff8e View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    64ce009 View commit details
    Browse the repository at this point in the history
  6. Reject invalid "Sec-WebSocket-Key" headers from clients

    Client "Sec-WebSocket-Key" should be a valid 16 byte base64 encoded
    nonce. If the header is not valid, the server should reject the
    client.
    Emyrk authored and nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    1a344a4 View commit details
    Browse the repository at this point in the history
  7. Remove build tag at top of files

    Emyrk authored and nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    f46da9a View commit details
    Browse the repository at this point in the history
  8. Remove all leading and trailing whitespace

    Emyrk authored and nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    3233cb5 View commit details
    Browse the repository at this point in the history
  9. Handle multiple sec-websocket-keys

    Emyrk authored and nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    309e088 View commit details
    Browse the repository at this point in the history
  10. misc: Format and compile #360

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    305eab9 View commit details
    Browse the repository at this point in the history
  11. Merge pull request #360 from Emyrk/emyrk/Sec-WebSocket-Key

    Reject invalid "Sec-WebSocket-Key" headers from clients
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    10137fa View commit details
    Browse the repository at this point in the history
  12. wsjs: Register OnError

    Closes #400
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    e361137 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    8abed3a View commit details
    Browse the repository at this point in the history
  14. conn_test: Add TestConcurrentClosePing

    Updates #298
    univerio authored and nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    e4879ab View commit details
    Browse the repository at this point in the history
  15. conn_test.go: Fix TestConcurrentClosePing

    Closes #298
    Closes #394
    
    The close frame was being received from the peer before we were able to reset our
    write timeout and so we thought the write kept failing but it never was...
    
    Thanks @univerio and @bhallionOhbibi
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    28c6709 View commit details
    Browse the repository at this point in the history
  16. close.go: Fix mid read close

    Closes #355
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    6cec2ca View commit details
    Browse the repository at this point in the history
  17. write.go: Fix potential writeFrame deadlock

    Closes #405
    
    You should always be reading from the connection with CloseRead so this shouldn't
    have affected anyone using the library correctly.
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    5fe95bb View commit details
    Browse the repository at this point in the history
  18. autobahn_test.go: Fix TODOs

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    308a8e2 View commit details
    Browse the repository at this point in the history
  19. ci/test.sh: Always benchmark

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    d22d1f3 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    50952d7 View commit details
    Browse the repository at this point in the history
  21. Update docs

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    9d9c971 View commit details
    Browse the repository at this point in the history
  22. netconn.go: Fix panic on zero or negative deadline durations

    Glad no one ran into this in production.
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    25a5ca4 View commit details
    Browse the repository at this point in the history
  23. ws_js.go: Add CloseNow

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    cdeb980 View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    fb3b083 View commit details
    Browse the repository at this point in the history
  25. Misc fixes

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    9fdcb5d View commit details
    Browse the repository at this point in the history
  26. Update README.md

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    db79f72 View commit details
    Browse the repository at this point in the history
  27. Update README.md

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    108d137 View commit details
    Browse the repository at this point in the history
  28. main_test.go: Add to detect goroutine leaks

    Updates #330
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    e6a7e0e View commit details
    Browse the repository at this point in the history
  29. Ensure no goroutines leak after Close

    Closes #330
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    6ed989a View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    d7a55cf View commit details
    Browse the repository at this point in the history
  31. README.md formatting fix

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    7b1a6bb View commit details
    Browse the repository at this point in the history
  32. wsjs: Ensure no goroutines leak after Close

    Closes #330
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    d91a212 View commit details
    Browse the repository at this point in the history
  33. Another README.md update

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    0caa997 View commit details
    Browse the repository at this point in the history
  34. Fix in README.md

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    7d8ddbc View commit details
    Browse the repository at this point in the history
  35. go.sum: Delete

    No longer needed :)
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    535fd2c View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    63c0405 View commit details
    Browse the repository at this point in the history
  37. Fix typo in README.md

    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    7ada249 View commit details
    Browse the repository at this point in the history
  38. ci/lint.sh: Remove golint

    Underscores in symbols are ok sometimes...
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    ff3ea39 View commit details
    Browse the repository at this point in the history
  39. examples/chat: Fix race condition

    Tricky tricky.
    nhooyr committed Oct 19, 2023
    Configuration menu
    Copy the full SHA
    af0fd9d View commit details
    Browse the repository at this point in the history